Add functions subgraph_edges and forest_cover_edge_sequence; refine similar_graph interface.#169
Merged
Conversation
jack-dunham
force-pushed
the
jd/subgraph_edges
branch
from
e81e340 to
bfbe1fb
Compare
…copy of its vertices and edges
This reverts commit deddcb8.
Previously existed in `ITensorNetworksNext`
This is to align with DataGraphs.jl and in analogy to SparseArrays.jl
jack-dunham
force-pushed
the
jd/subgraph_edges
branch
from
bfbe1fb to
c19762a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 79.67% 78.99% -0.69%
==========================================
Files 55 55
Lines 2111 2099 -12
==========================================
- Hits 1682 1658 -24
- Misses 429 441 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfishman
reviewed
May 14, 2026
mtfishman
reviewed
May 14, 2026
mtfishman
reviewed
May 14, 2026
…st argument Previously, used `promote_type`. This is to align more with existing `Base.union` methods.
- Removed the need to copy in `similar_graph` - Updated the inner constructor for `GenericNamedGraph` - Removed two outer constructors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
similar_graphmethods that took edges as an argument (these were removed in DataGraphs.jl , but not in NamedGraphs.jl yet.),subgraph_edgesfunction.forest_cover_edge_sequencefunction, that is currently sitting out-of-place in ITensorNetworksNext.jl, into NamedGraphs.GraphsExtensions.