Skip to content

Conversation

@mtfishman
Copy link
Member

This is essentially the same code as ITensors.SiteTypes, but with a few tweaks to make it compatible with ITensorBase.jl.

@emstoudenmire
Copy link

I agree it's a good time to split these off.

@mtfishman
Copy link
Member Author

mtfishman commented Jan 19, 2025

I agree it's a good time to split these off.

@emstoudenmire glad you agree. I also plan to experiment with some new designs here, and delete code that we've been keeping around for backwards compatibility that is making things unnecessarily complicated and hard to modify/maintain.

Note that I chose a deliberately verbose name since I also plan to split this up even more, for example I want to split off parts that aren't specific to ITensor into a package QuantumOperatorDefinitions.jl, and then this package can probably just be a package extension that gets triggered to load when ITensors.jl and QuantumOperatorDefinitions.jl are both loaded. (EDIT: And of course I'm open to other names, nothing is set in stone yet.)

@mtfishman mtfishman changed the title First commit First commit (move code from ITensors.jl) Jan 19, 2025
@mtfishman mtfishman merged commit f11870e into main Jan 19, 2025
8 of 9 checks passed
@mtfishman mtfishman deleted the first_commit branch January 19, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants