JsonRpcConnection#Disconnect(): don't cleanly shutdown TLS (nor TCP)#10220
Closed
JsonRpcConnection#Disconnect(): don't cleanly shutdown TLS (nor TCP)#10220
Conversation
…er cancelling I/O While #Disconnect() is running in foreground on #m_IoStrand, #WriteOutgoingMessages() could wait for #m_OutgoingMessagesQueued or, theoretically, pending I/O. Also cancelling such I/O makes sense, to wake up #WriteOutgoingMessages() first if necessary.
The TCP connection may be broken, e.g. by some firewall (or attacker) in the middle, so that the TLS shutdown takes longer than necessary, if it even completes successfully. On the other hand, the peer isn't a browser, but also an Icinga 2 node, designed to handle TLS stream truncation (what effectively happens now) gracefully. A clean TLS shutdown also doesn't improve security as, again, a MITM could prevent it.
It's neither cleanly shutting down TLS already, so the TCP stream may also be truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TCP connection may be broken, e.g. by some firewall (or attacker) in the middle, so that the TLS shutdown takes longer than necessary, if it even completes successfully.
On the other hand, the peer isn't a browser, but also an Icinga 2 node, designed to handle TLS/TCP stream truncation (what effectively happens now) gracefully. A clean TLS shutdown also doesn't improve security as, again, a MITM could prevent it.
closes #10210