Remove clear variable from disk CheckCommand#10531
Merged
oxzi merged 2 commits intoIcinga:masterfrom Aug 19, 2025
Merged
Conversation
This commit removes the -C parameter from the disk CheckCommand since there is no possible way to use it in any functional capacity. -C (or --clear) would reset the thresholds given previously to allow for setting different thresholds for following filesystmes. As an example: check_disk -w 50% -c 5% -p / -C -w 1% -p /home would only set the warning threshold for /home. Since there is no way to use it reasonaly with the Icinga 2 implementation of check_disk (since thresholds can only be given once and the order is undefined), the clear flag has no worth here. My suggestion is to remove it avoid suggesting that it might be used, but I left it as a comment in the ITL to prevent the next person from "adding a missing parameter".
oxzi
reviewed
Aug 18, 2025
Member
oxzi
left a comment
oxzi
left a comment
There was a problem hiding this comment.
Thanks for your PR. Seems to work as intended.
For reference:
$ /usr/local/libexec/nagios/check_disk -w 100% -c 100%
DISK CRITICAL [ . . . ]
$ /usr/local/libexec/nagios/check_disk -w 100% -c 100% -C
DISK OK [ . . . ]
oxzi
approved these changes
Aug 19, 2025
Member
oxzi
left a comment
oxzi
left a comment
There was a problem hiding this comment.
LGTM.
FTR, should be merged as a squashed commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
-Cparameter from thediskCheckCommand since there is no possible way to use it in any functional capacity.-C(or--clear) would reset the thresholds given previously to allow for setting different thresholds for following filesystmes. As an example:would only set the warning threshold for /home.
Since there is no way to use it reasonaly with the Icinga 2 implementation of check_disk (since thresholds can only be given once and the order is undefined), the clear flag has no worth here.
My suggestion is to remove it avoid suggesting that it might be used, but I left it as a comment in the ITL to prevent the next person from "adding a missing parameter".