Skip to content

SELinux: allow to query attrs of a filesystem#10726

Merged
yhabteab merged 1 commit intomasterfrom
selinux-getattr-fix
Mar 31, 2026
Merged

SELinux: allow to query attrs of a filesystem#10726
yhabteab merged 1 commit intomasterfrom
selinux-getattr-fix

Conversation

@yhabteab
Copy link
Copy Markdown
Member

On some Linux distributions, boost::filesystem::copy_file emits a fstatfs syscall to query the filesystem metadata to determine if it can use copy_file_range or if it needs to fall back to a read/write loop. Denying this syscall does not cause any functional issues, as the fallback logic is also used in case of EACCES, but it prevents the use of copy_file_range which can lead to significant performance improvements when copying large files. For more details see #10711 (comment).

I've started a Pipeline for this here (is not publicly accessible) to test whether the interface is available on all our supported distros.

fixes #10711

@yhabteab yhabteab added the bug Something isn't working label Feb 23, 2026
@cla-bot cla-bot bot added the cla/signed label Feb 23, 2026
@yhabteab yhabteab requested a review from julianbrost February 23, 2026 12:59
@yhabteab yhabteab added this to the 2.16.0 milestone Mar 17, 2026
@yhabteab yhabteab requested review from lippserd and removed request for julianbrost March 18, 2026 15:36
@yhabteab yhabteab removed the request for review from lippserd March 27, 2026 10:15
@julianbrost julianbrost requested a review from oxzi March 31, 2026 08:07
Copy link
Copy Markdown
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I was unable to reproduce the reported issue. However, the change looks fine to me. So, merge it, I'd say.

@yhabteab yhabteab merged commit e449fec into master Mar 31, 2026
31 of 32 checks passed
@yhabteab yhabteab deleted the selinux-getattr-fix branch March 31, 2026 14:38
@yhabteab yhabteab mentioned this pull request Apr 1, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SELinux is preventing /usr/lib64/icinga2/sbin/icinga2 from getattr access on the filesystem /var on Rocky 10

2 participants