Add check_smart.pl plugin as smart-advanced command#8041
Add check_smart.pl plugin as smart-advanced command#8041yhabteab merged 1 commit intoIcinga:masterfrom
Conversation
|
Hi guys, do you still need something from me? I'm not sure from the notes above. |
|
I think we mainly have to agree on notation here. Meanwhile, I could remember a similar case with different checks: Always put the device name in @Al2Klimov What do you think of this? For reference, this is how it's done for icinga2/itl/plugins-contrib.d/databases.conf Lines 519 to 523 in 4308979 |
|
@julianbrost OK let's try the latest version, see my commit ca9fcf3. I'm using the same way from your example with from |
julianbrost
left a comment
There was a problem hiding this comment.
In addition to the comments below, please also squash your changes into a single commit.
julianbrost
left a comment
There was a problem hiding this comment.
The new file also has to be added in itl/plugins-contrib.d/CMakeLists.txt so that it will actually be used.
|
This is now 1y pending ... still no improvement yet. |
|
Yes, that's on me. I always need some time to re-think into that issue every time, but some disasters always come in between. Sorry about that. |
yhabteab
left a comment
There was a problem hiding this comment.
I see some arguments in the docs that aren't part of this PR and I'm not sure whether they are new or not. However, this PR is open for far too long now, and I think I would just merge it unles @julianbrost says otherwise, since you're the one actively changes requested here, which AFAICS are all addressed.
|
Yes, looks like what I requested was addressed, but then this PR completely fell under the radar. Sorry about that. |
|
I've rebased and squashed the commits! Thanks for your contribution. |
This PR adds the check_smart.pl monitoring plugin under the
smart-advancedcheck command (smartis already used by the check_ide_smart plugin).