[ITL] Added some ignore options for check_ssl_cert#9512
[ITL] Added some ignore options for check_ssl_cert#9512julianbrost merged 2 commits intoIcinga:masterfrom
Conversation
fabieins
commented
Sep 5, 2022
fabieins
commented
- ssl_cert_ignore_ocsp_errors | Optional. Continue if the OCSP status cannot be checked
- ssl_cert_ignore_ocsp_timeout | Optional. Ignore OCSP result when timeout occurs while checking
- ssl_cert_ignore_host_cn | Optional. Do not complain if the CN does not match
|
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @fabieins Details
|
|
the CLA is signed
Am 05.09.22 um 15:09 schrieb cla-bot[bot]:
… Thank you for your pull request. Before we can look at it, you'll need
to sign a Contributor License Agreement (CLA).
*Please follow instructions at
https://icinga.com/company/contributor-agreement
<https://icinga.com/company/contributor-agreement> to sign the CLA.*
After that, please reply here with a comment and we'll verify.
Contributors that have not signed yet: @fabieins
<https://github.com/fabieins>
*
If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Please
contact us <https://icinga.com/company/contact/> if you think this
is the case.
*
If you signed the CLA as a corporation, your GitHub username may not
have been submitted to us. Please reach out to the responsible
person in your organization.
—
Reply to this email directly, view it on GitHub
<#9512 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLD7YVDQTPHDRMFJGJ4LETV4XWH5ANCNFSM6AAAAAAQE7JIO4>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
/**
* Fabian Werner
* Systementwickler
*
* synyx GmbH & Co. KG
* Code with Attitude
* Gartenstraße 67
* 76135 Karlsruhe
*
* Telefon +49 721 203823-32
* Fax +49 721 203823-12
* E-Mail ***@***.***
* Web https://www.synyx.de
* Blog https://blog.synyx.de
*
* Sitz der Gesellschaft: Karlsruhe
* Registergericht: Mannheim
* Handelsregisternummer: HRA 104793
* USt-IdNr.: DE249264296
*
* Komplementärin: synyx Verwaltung GmbH
* Sitz der Gesellschaft: Karlsruhe
* Geschäftsführer:
* Thomas Kraft, Markus Daniel, Joachim Arrasz
* Registergericht: Mannheim
* Handelsregisternummer: HRB 107250
*/
|
|
@cla-bot check |
|
How does it go on here? |
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
How does it go on here? Do I have to do anything?
Until just now no, just mail backlog and unfortunate timing, sorry about that.
doc/10-icinga-template-library.md
Outdated
| ssl_cert_ignore_expiration | **Optional.** Ignore expiration date. | ||
| ssl_cert_ignore_ocsp | **Optional.** Do not check revocation with OCSP. | ||
| ssl_cert_ignore_ocsp_errors | **Optional.** Continue if the OCSP status cannot be checked | ||
| ssl_cert_ignore_ocsp_timeout | **Optional.** Ignore OCSP result when timeout occurs while checking | ||
| ssl_cert_ignore_sct | **Optional.** Do not check for signed certificate timestamps. | ||
| ssl_cert_ignore_tls_renegotiation | **Optional.** Do not check for renegotiation. | ||
| ssl_cert_ignore_host_cn | **Optional.** Do not complain if the CN does not match |
There was a problem hiding this comment.
I wonder why the ordering differs between the changes in both files. So far, at least the ignore options seem to be ordered alphabetically, so I'd keep it this way. Also, most (unfortunately not all) descriptions end with a period, so I'd keep most of them consistent and add them here as well.
There was a problem hiding this comment.
In the web.conf it was a try to keep the order of the output of check_ssl_cert -h version 2.40.0.
The descriptions are also taken from this help output and there is no period.
There was a problem hiding this comment.
In the web.conf it was a try to keep the order of the output of
check_ssl_cert -hversion 2.40.0.
The order in web.conf is fine. I suggest to use the same in 10-icinga-template-library.md.
The descriptions are also taken from this help output and there is no period.
So is the description for --ignore-ocsp which is also consistent with the majority of options in that file, so I opt for adding the period.
* ssl_cert_ignore_ocsp_errors | **Optional.** Continue if the OCSP status cannot be checked * ssl_cert_ignore_ocsp_timeout | **Optional.** Ignore OCSP result when timeout occurs while checking * ssl_cert_ignore_host_cn | **Optional.** Do not complain if the CN does not match
* fix order * add a period at the end of the description.
fabieins
force-pushed
the
feature/check_ssl_cert
branch
from
f789024 to
0ae3625
Compare
3 participants
