Skip to content

Conversation

@sukhwinder33445
Copy link
Contributor

resolves #1095

@sukhwinder33445 sukhwinder33445 added the enhancement New feature or improvement label Jan 9, 2025
@sukhwinder33445 sukhwinder33445 self-assigned this Jan 9, 2025
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jan 9, 2025
@raviks789
Copy link
Contributor

The object name is also shown along with the templates imported as shown in the screenshot below, which IMO opinion must be removed.

Screenshot 2025-01-10 at 13 46 55

@sukhwinder33445
Copy link
Contributor Author

I forgot to mark it as a to-do, thanks for mentioning. This must be fixed.

@nilmerg
Copy link
Member

nilmerg commented Apr 14, 2025

which IMO opinion must be removed.

Why? It's what the API returns, isn't it? The source tab is meant to provide raw information.

@raviks789
Copy link
Contributor

which IMO opinion must be removed.

Why? It's what the API returns, isn't it? The source tab is meant to provide raw information.

That may be true, but IMO this raw information looks confusing. In the first place we only want the templates to be shown in the source tab. So in that case we could either handle it here or the API has to return only the templates and not include the object name.

@nilmerg
Copy link
Member

nilmerg commented Apr 14, 2025

It's totally out of scope to adjust what the API returns. And we should not hide anything provided by it. The information might be confusing to you. For me this is a template tree in which case a root is required and that's the object itself.

Anyway, the source tab is meant to provide raw information. Some of it might be represented differently (timestamps -> datetime, bool -> yes|no), but it never should hide anything.

@nilmerg nilmerg added this to the 1.2.0 milestone May 8, 2025
@nilmerg nilmerg merged commit 7866063 into main Jun 5, 2025
22 checks passed
@nilmerg nilmerg deleted the feature/show-template-of-host-srvice-in-source-tab branch June 5, 2025 10:33
@nilmerg nilmerg removed the request for review from raviks789 June 5, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show templates of host/service in source tab

4 participants