Escape special chars in form element name #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
6 times, most recently
from
f463eb3 to
649c3e5
Compare
This was referenced Aug 12, 2025
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
8 times, most recently
from
ab7e654 to
178d3d3
Compare
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
from
178d3d3 to
40a7abd
Compare
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
from
40a7abd to
9b401f9
Compare
nilmerg
requested changes
Sep 4, 2025
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
3 times, most recently
from
83aa91f to
0510d69
Compare
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
5 times, most recently
from
8916b57 to
b832e52
Compare
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
2 times, most recently
from
3d8079b to
c45ea5d
Compare
nilmerg
requested changes
Sep 22, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
Please also test the changes made to populate() and registerElement(). And those made to BaseFormElement::setName().
nilmerg
requested changes
Sep 22, 2025
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
from
91fe28b to
b28b3d2
Compare
nilmerg
requested changes
Sep 25, 2025
Member
|
And please fix the conflicts |
The special characters, '.' or '-' will be replaced by '_' in element names during rendering to make the form element names to be compatible with PHP post data.
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
2 times, most recently
from
dbdca62 to
e3eb3aa
Compare
raviks789
force-pushed
the
fix/escape-special-chars-in-element-name
branch
from
e3eb3aa to
79dd30a
Compare
nilmerg
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #149