TestConnection: Mock essential methods #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
mock-test-connection-properly
branch
from
350928e to
d0643ff
Compare
So that using it works somewhat. It is still not a mock that's configurable, i.e. it doesn't provide any results, but this is better than being fully unusable.
nilmerg
force-pushed
the
mock-test-connection-properly
branch
from
d0643ff to
7a3875a
Compare
Member
Author
|
not sure why phpstan fails 🤷♂️ |
nilmerg
added a commit
that referenced
this pull request
Dec 17, 2024
Slipped through in #88 as it's not used at all here. Now a test exists which does.
nilmerg
added a commit
that referenced
this pull request
Dec 17, 2024
Slipped through in #88 as it's not used at all here. Now a test exists which does.
nilmerg
added a commit
that referenced
this pull request
Dec 17, 2024
Slipped through in #88 as it's not used at all here. Now a test exists which does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that using it works somewhat. It is still not a mock that's configurable, i.e. it doesn't provide any results, but this is better than being fully unusable.