Add Seq::map() and Filter\Chain::yieldRules()#75
Merged
Conversation
Contributor
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
Code looks good.
Allows to produce a flat sequence of rules to iterate over.
Allows to apply a callback to any iterable, unlike array_map.
nilmerg
force-pushed
the
add-seq-map-and-chain-yieldRules
branch
from
050b04b to
9ad3e49
Compare
BastianLedererIcinga
approved these changes
May 22, 2026
nilmerg
added a commit
to Icinga/icinga-notifications-web
that referenced
this pull request
May 22, 2026
resolve #466 Introduce `RuleSerializer` to create Json from a configured filter. Introduce `Icinga\Module\Notifications\Hook\V2` which no longer requires `serializeRuleFilter()` and `getRuleFilterTargets()` as they are now obsolete. Adjust `EventRuleController` to skip target selection use the new `RuleSerializer`. require Icinga/ipl-web#380 require Icinga/ipl-web#383 require Icinga/ipl-stdlib#75 require Icinga/ipl-stdlib#76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.