CompatForm: Add missing Errors decorator#322
Merged
Conversation
sukhwinder33445
force-pushed
the
fix/add-missing-errors-decorator
branch
from
dfde4c2 to
adccdfb
Compare
nilmerg
requested changes
Oct 27, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
Missing tests. Since this was uncovered by accident now, this is an even more clear indication that tests are required.
sukhwinder33445
force-pushed
the
fix/add-missing-errors-decorator
branch
from
a5413df to
e65a532
Compare
sukhwinder33445
changed the base branch from
compat-form-compat-with-ipl-html
to
main
sukhwinder33445
force-pushed
the
fix/add-missing-errors-decorator
branch
2 times, most recently
from
1851dae to
d3cfc5f
Compare
sukhwinder33445
changed the base branch from
main
to
compat-form-compat-with-ipl-html
sukhwinder33445
force-pushed
the
fix/add-missing-errors-decorator
branch
3 times, most recently
from
13f47ef to
5dbe5a1
Compare
nilmerg
force-pushed
the
compat-form-compat-with-ipl-html
branch
from
a6ca114 to
2c37cb0
Compare
Member
|
please rebase |
sukhwinder33445
force-pushed
the
fix/add-missing-errors-decorator
branch
from
5dbe5a1 to
f59d31e
Compare
nilmerg
requested changes
Oct 28, 2025
If the form validation failed, the form could not be submitted and no errors were displayed because the error decorator is missing. This is why there was no indication to the user about why the submit button was not working. - Remove unused imports and add new lines
sukhwinder33445
force-pushed
the
fix/add-missing-errors-decorator
branch
from
f59d31e to
25b3715
Compare
nilmerg
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the form validation failed, the form could not be submitted and no errors were displayed because the error decorator is missing. This is why there was no indication to the user about why the submit button was not working.