Support rich labels in SearchSuggestions#366
Conversation
Allow `ValidHtml` to be passed via the `label-html` key which is then rendered inside a `button` element. css selectors are adjusted to have increased specificity because otherwise the button elements are styled by icingaweb2.
There was a problem hiding this comment.
@raviks789 Please test this with your Director customvar changes, since you make heavy use of the TermInput there.
The location of .suggestions changed to outside the form now and accumulate there in case of multiple instances.
|
@nilmerg just did a simple test. The suggestions are not displayed for data lists with this branch. See the screen shots below: main branch: feature/rich-suggestion-labels branch: |
|
I could not think of a clever solution that fixes the problem with the fieldsets, but maybe Claude did: I left the comments it made for now so it's easier to evaluate if the approach makes sense at all, if we want to use it I'm going to clean it up. |
|
I'm not sure whether this approach is correct. It looks promising, but it changes the timing of when fieldsets are assembled. Though, at least only for fieldsets. But I'd like to perform proper testing and right now there's not enough time for this. So please open a separate pull request for it and restore the |
BastianLedererIcinga
force-pushed
the
feature/rich-suggestion-labels
branch
from
d97fb15 to
8cdc2de
Compare
3 participants
Allow providers of
SearchSuggestionsto passValidHtmlvia thedetailskey, which is rendered inside abuttonelement.resolve #364