Skip to content

Make less variables independent from other modules#46

Merged
nilmerg merged 7 commits intomasterfrom
add-default-values-for-less-variables
Nov 8, 2021
Merged

Make less variables independent from other modules#46
nilmerg merged 7 commits intomasterfrom
add-default-values-for-less-variables

Conversation

@sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Oct 4, 2021 •
edited
Loading

fixes #23

@cla-bot cla-bot bot added the cla/signed label Oct 4, 2021
@sukhwinder33445 sukhwinder33445 self-assigned this Oct 4, 2021
@sukhwinder33445 sukhwinder33445 added the enhancement New feature or request label Oct 4, 2021
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch 3 times, most recently from aca1cdc to e389610 Compare October 6, 2021 16:49
@sukhwinder33445
Copy link
Contributor Author

sukhwinder33445 commented Oct 6, 2021

fade(), darken() does not work with css var(). I am still searching for a solution.

@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from bcd6ab6 to 6c8733a Compare October 8, 2021 09:56
@sukhwinder33445 sukhwinder33445 linked an issue Oct 8, 2021 that may be closed by this pull request
Non-existing less mixins and variables are used #23
Closed
@sukhwinder33445 sukhwinder33445 added bug Something isn't working and removed enhancement New feature or request labels Oct 8, 2021
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from cef4dec to 24d4245 Compare October 8, 2021 12:28
sukhwinder33445 added a commit to Icinga/icingaweb2 that referenced this pull request Oct 8, 2021
@sukhwinder33445
Remove mixins that exist in ipl-web
627ff61 
To make ipl-web independent, all mixins used in ipl-web are now
defined in ipl-web (Icinga/ipl-web#46).
Therefore, these mixins are redundant here.
@sukhwinder33445 sukhwinder33445 mentioned this pull request Oct 8, 2021
Merged
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from 24d4245 to 3640139 Compare November 4, 2021 09:14
sukhwinder33445 added a commit to Icinga/icingaweb2 that referenced this pull request Nov 4, 2021
@sukhwinder33445
Remove mixins that exist in ipl-web
37fbdae 
To make ipl-web independent, all mixins used in ipl-web are now
defined in ipl-web (Icinga/ipl-web#46).
Therefore, these mixins are redundant here.
@nilmerg nilmerg added this to the v0.3 milestone Nov 4, 2021
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from 3640139 to 5eb53dc Compare November 4, 2021 11:40
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from 5eb53dc to 0052408 Compare November 4, 2021 12:01
sukhwinder33445
sukhwinder33445 commented Nov 4, 2021
View reviewed changes
@sukhwinder33445 sukhwinder33445 requested review from nilmerg and removed request for nilmerg November 4, 2021 13:10
@nilmerg nilmerg mentioned this pull request Nov 5, 2021
Closed
3 tasks
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch 3 times, most recently from acbe978 to eb8e43f Compare November 5, 2021 15:46
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch 3 times, most recently from e54313b to c381ebc Compare November 8, 2021 09:46
nilmerg
nilmerg requested changes Nov 8, 2021
View reviewed changes
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from c381ebc to 4bdf401 Compare November 8, 2021 09:56
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch 2 times, most recently from 2742928 to a441143 Compare November 8, 2021 13:54
@sukhwinder33445 sukhwinder33445 requested review from flourish86 and removed request for flourish86 November 8, 2021 13:55
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from a441143 to 6aa3f59 Compare November 8, 2021 15:12
nilmerg
nilmerg reviewed Nov 8, 2021
View reviewed changes
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from 6aa3f59 to d956584 Compare November 8, 2021 15:43
@sukhwinder33445 sukhwinder33445 force-pushed the add-default-values-for-less-variables branch from d956584 to b7121fc Compare November 8, 2021 15:46
@flourish86 flourish86 force-pushed the add-default-values-for-less-variables branch from c3e4f40 to 75d8cb2 Compare November 8, 2021 16:06
@nilmerg nilmerg merged commit 549100a into master Nov 8, 2021
@nilmerg nilmerg deleted the add-default-values-for-less-variables branch November 8, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilmerg nilmerg nilmerg approved these changes

@flourish86 flourish86 Awaiting requested review from flourish86

Assignees

@sukhwinder33445 sukhwinder33445

Labels

bug Something isn't working cla/signed

Projects

None yet

Milestone

v0.3

Development

Successfully merging this pull request may close these issues.

Non-existing less mixins and variables are used

3 participants

@sukhwinder33445 @nilmerg @flourish86