fix: stop the keyboard from closing immediately after opening because of a valuekey update#93
Merged
freekvandeven merged 1 commit intomasterfrom May 16, 2025
Conversation
FlutterJoey
approved these changes
May 16, 2025
d320ca3 to
4dcdd59
Compare
… of a valuekey update The hashcode of the LoginOptions was not consistent so it would force the field to rebuild when the keyboard would open. I added equatable to get a reliable hashCode.
4dcdd59 to
92adcfc
Compare
Quirille
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hashcode of the LoginOptions was not consistent so it would force the field to rebuild when the keyboard would open. The ValueKey was not needed at all for hot reloading so I removed it.