Catch SAML logout errors and display error view #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That's quite good for me, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am running Django 3.1.1 + PySAML 6.1.0 + djangosaml master
When trying to logout from the IDP after the SSO session has expired (but while the Django session is still valid), the IDP responds with the following status:
and an exception is thrown in
client.parse_logout_request_response, which is not catched by djangosaml and ends up with a HTTP code 500.I propose to catch this exception and display a graceful error page in
finish_logoutinstead.My ultimate goal is to ignore this error, which I will propose in another PR, but it is a more controversial change, so I am proposing this one separately.