Fix for overriding custom error view using SAML_ACS_FAILURE_RESPONSE_FUNCTION #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `import_string` import so that you can use the above variable to supply a different template rendering function.
The custom error function that is passed in using SAML_ACS_FAILURE_RESPONSE_FUNCTION has changed signature and the example no longer works. The custom function with an extra positional argument so the documentation has been updated to include this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom error view call was using the
import_stringfunction but this function wasn't being imported in the file so it resulted in an error at runtime.Additionally the documentation describing how to do this has a small error with the example function you need to override. I guess at some point in the past
statuswas added as a positional argument.