Handle missing token exchange requested_token_type parameter#18
Merged
rohe merged 1 commit intoIdentityPython:developfrom May 14, 2022
Merged
Conversation
Contributor
Author
|
Should we enforce that |
Contributor
|
Pushing responsibility to the user is almost never a good thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to OAuth 2.0 Token Exchange the
requested_token_typeof a Token Exchange request is optional. In the case where this parameter is missing from the request, a KeyError is raised.To solve this issue, this MR introduces a mandatory configuration parameter
default_requested_token_typefor theTokenExchangeHelperconfiguration.