This repository was archived by the owner on Jun 12, 2021. It is now read-only.
Fix bug, add_claims_by_scope was not used#29
Merged
rohe merged 1 commit intoIdentityPython:masterfrom Jan 3, 2020
Merged
Conversation
Contributor
|
Please do ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JWTToken the
add_claims_by_scopeparameter was not used, now it defaults to False.IMO the default behaviour should be that if
add_claims_by_scopeis True thenscope_claims_mapdefaults to thescope2claimsdict found in endpoint_context.If you agree with that I can implement it.