Skip to content

Conversation

@mrvanes
Copy link
Contributor

@mrvanes mrvanes commented May 29, 2017

This fix enables "bare" aliases to be succesfully retrievable via /alias requests. The main reason turns out to be an error in inlince doc in builtins.py.

This fix enables "bare" aliases to be succesfully retrievable via /alias requests. The main reason turns out to be an error in inlince doc in builtins.py.
@leifj
Copy link
Contributor

leifj commented May 29, 2017

Can you help me figure out why the test fails? I'm not ruling out the possibility that the test is broken or just failed randomly but I also wan't to make sure this fix doesn't break anything.

@mrvanes
Copy link
Contributor Author

mrvanes commented May 29, 2017

I'm not a travis expert, but I can try.
The test PR seems ok. But here I see things like this:

root: ERROR: Generating RSA private key, 2048 bit long modulus
...........+++
...........................................................+++
unable to write 'random state'
e is 65537 (0x10001)

I just don't understand why a pull request with harmless comment does not trip on this as well?

@leifj
Copy link
Contributor

leifj commented May 29, 2017

Thats actually not an error but stdout from a successful test. Look for "FAIL"

@mrvanes
Copy link
Contributor Author

mrvanes commented May 29, 2017

The

- select as /ndn

in test_alias_ndn PyFFDTest fails, as is to be expected. Back to the drawing board to see how we can discriminate between true and false positives for the strip("/").

Or, correct the inline documentation in builtins.py?

mrvanes added 2 commits May 29, 2017 16:08
Revert strip("/") fix.
Move strip("/") fix to store.py where a fallback check can be or'd with the original check. This makes distinction between /alias and alias impossible.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.501% when pulling eecaf95 on mrvanes:patch-1 into 1d032fe on leifj:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.501% when pulling eecaf95 on mrvanes:patch-1 into 1d032fe on leifj:master.

@mrvanes
Copy link
Contributor Author

mrvanes commented May 29, 2017

If you agree with the replacement of the strip("/") to store.py this PR looks fine now.

@leifj
Copy link
Contributor

leifj commented Jan 17, 2018

Reviewing old PRs (sorry about the delay) - can you help me unconflict this PR and also perhaps provide a testcase that demonstrates the breakage?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6e0d25d on mrvanes:patch-1 into ** on leifj:master**.

@mrvanes
Copy link
Contributor Author

mrvanes commented Sep 23, 2019

It's clear from the docs now that the alias is actually a path and needs the leading /

@mrvanes mrvanes closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants