Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase query match string for process_handler #175

Merged

Conversation

@skoranda
Copy link
Contributor

commented Jul 28, 2019

Add logic to lowercase the query text or match string for the
process_handler to make its behavior consistent with the API
search_handler so that a frontend can point at either search URL and
observe the same case behavior.

All Submissions:

  • [X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [X ] Have you added an explanation of what problem you are trying to solve with this PR?
  • [X ] Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?

There does not appear to be a test harness yet for testing the process_handler.

  • [ X] Does your submission pass tests?

The same tests pass before and after the change.

  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

The current code base is not following PEP8 at this time.

Lowercase query match string for process_handler
Add logic to lowercase the query text or match string for the
process_handler to make its behavior consistent with the API
search_handler so that a frontend can point at either search URL and
observe the same case behavior.
@coveralls

This comment has been minimized.

Copy link

commented Jul 28, 2019

Coverage Status

Coverage remained the same at 68.438% when pulling f385e99 on skoranda:lowercase_query_process_handler into a7eeafb on IdentityPython:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Jul 28, 2019

Coverage Status

Coverage remained the same at 68.438% when pulling f385e99 on skoranda:lowercase_query_process_handler into a7eeafb on IdentityPython:master.

@leifj leifj merged commit 0014e21 into IdentityPython:master Jul 28, 2019

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.438%
Details
license/snyk - requirements.txt (SUNET) No manifest changes detected
security/snyk - requirements.txt (SUNET) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.