Skip to content

Conversation

@rhoerbe
Copy link
Contributor

@rhoerbe rhoerbe commented Jul 13, 2016

This is an unobtrusive extension for pyff to facilitate the generation of ADFS-compatible metadata, which can be consumed like a metadata aggregate conforming to SAMLMetaIOP. Requires the c14n fix provided in a previous PR.

Doc: see src/pyff/mdsplit.py and sccripts/pyff_mdsplit.py

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.536% when pulling f0f7b94 on identinetics:mdsplit into 063f0de on leifj:master.

@leifj
Copy link
Contributor

leifj commented Jul 13, 2016

The way I understand this it duplicates existing functions in pyFF - notably the store builtin which already stores metadata in one-entitydesciprtor-per-file. I am not going to add new cmdlines to pyFF just to wrap a particular class of pipelines.

@rhoerbe
Copy link
Contributor Author

rhoerbe commented Jul 13, 2016

Maybe I did not understand how to achieve this with the builtin.

Am 13.07.2016 um 21:57 schrieb Leif Johansson notifications@github.com:

On 2016-07-13 21:47, Rainer Hörbe wrote:

This is an unobtrusive extension for pyff to facilitate the generation
of ADFS-compatible metadata, which can be consumed like a metadata
aggregate conforming to SAMLMetaIOP. Requires the c14n fix provided in a
previous PR.

Doc: see src/pyff/mdsplit.py and sccripts/pyff_mdsplit.py

This duplicates functionality that already exists in pyFF so I don't
think I'll merge it - at least not until I understand what this adds
beyond the existing store builtin.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #95 (comment), or mute the thread https://github.com/notifications/unsubscribe/AEJaP6zRVtZeZMy_vwGZ8d1VFg5DtveBks5qVUMSgaJpZM4JLx77.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.536% when pulling f0f7b94 on identinetics:mdsplit into 063f0de on leifj:master.

@rhoerbe
Copy link
Contributor Author

rhoerbe commented Jul 13, 2016

An example or doc how to create signed per-ed files would be good

@leifj
Copy link
Contributor

leifj commented Jul 14, 2016

Skickat från min iPhone

13 juli 2016 kl. 22:03 skrev Rainer Hörbe notifications@github.com:

An example or doc how to create signed per-ed files would be good

Signing each file is new but is a relatively simple pipe to write - possibly an extension to store. That pull request I would consider. I don't see the value of adding cmdline tools for this usecase though.

@leifj leifj closed this Jul 14, 2016
@leifj
Copy link
Contributor

leifj commented Jul 14, 2016

I will entertain a pull request that implements signing as an option to store but doesn't introduce a bunch of new and redundant cmdline tools.

@rhoerbe
Copy link
Contributor Author

rhoerbe commented Jul 14, 2016

I might do this once I have a better understanding (or documentation) of the plumbing stuff. For the time being I will have to bear to work with the fork, which is doing the job.

@leifj
Copy link
Contributor

leifj commented Jul 14, 2016

On 2016-07-14 13:44, Rainer Hörbe wrote:

I might do this once I have a better understanding (or documentation) of
the plumbing stuff. For the time being I will have to bear to work with
the fork, which is doing the job.

Pipes are fully documented using pydoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants