reducers registery and all it implies#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored the Reducer trait and individual reducers.
Added ReducerRegistery which maps channels to reducers and wired it into the main App.
the barrier function aggregates changes to a new PartialNode (will probably change how that works in the future) and sends it to ReducerRegistery::apply_all.
then ReducerRegistery loops over all channel types and for each of them applies the related reducers on the main state.
TODO:
prettify barrier function, version bumping and aggregation.
trace errors carefully, we might be losing reducer errors on the overall apply_all