XmlSerializer.cpp at Serializers_ifc2x3 compile failed!!!

[geo3data]

Bug Description

src\serializers\schema_dependent\XmlSerializer.cpp

#ifdef SCHEMA_HAS_IfcPropertySetDefinitionSet
aggregate_ofIfcSchema::IfcPropertySetDefinitionSet::ptr property_set_sets = get_related
<IfcSchema::IfcObject, IfcSchema::IfcRelDefinesByProperties, IfcSchema::IfcPropertySetDefinitionSet>
(object, &IfcSchema::IfcObject::IsDefinedBy, &IfcSchema::IfcRelDefinesByProperties::RelatingPropertyDefinition);

	for (auto& s : *property_set_sets) {
		 property_sets->push((decltype(property_sets))*s);
	}

#endif

i guess you forget #ifdef SCHEMA_HAS_IfcPropertySetDefinitionSet ,IfcPropertySetDefinitionSet only works in IFC4

Attachments

No response

Debug and Error Output

[RickBrice]

@geo3data you might be working with old code. I searched through src/serializers/schema_dependent/XmlSerializer.cpp and don't see the block of code you reference or the SCHEMA_HAS_IfcPropertySetDefinitionSet macro.

Are you using the v0.8.0 branch?

[RickBrice]

@geo3data I am now experiencing the same problem.
It looks like it is related to 858e73c by @aothms

[geo3data]

@RickBrice ,that is right. because I cannot commit, so i changed the code on my computer,and opened this issue.

[aothms]

Thank you for the report. Indeed, I had locally only IFC4X3_ADD2 activated so didn't notice the lack of compatibility with 2X3 (I should have though)

because I cannot commit, so i changed the code on my computer

@geo3data The typical way of working with this is to commit to your local 'fork' of the project and from there send in a 'pull request' [0]. Since you have the changes locally, would be much appreciated if you follow through on this.

[0] https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

[sboddy]

As #6565 is closed, and this issue is a duplicate of that one, then logically this can be closed too.

[Moult]

@sboddy its the other way around. The other bug is a duplicate of this one.

[sboddy]

Sorry, my bad.