-
-
Notifications
You must be signed in to change notification settings - Fork 845
Description
Bug Description
In #6196 (comment) @Breogan10 noticed that there is a discrepancy between Bonsai's ifcopenshell build and build from https://builds.ifcopenshell.org/ - modules mvd and simple_spf.
The reason why they are missing - in bonsai daily CI we checkout repo but don't download submodules.
IfcOpenShell/.github/workflows/ci-bonsai-daily.yml
Lines 56 to 61 in 718254f
| steps: | |
| - uses: actions/checkout@v2 | |
| - uses: actions/setup-python@v2 # https://github.com/actions/setup-python | |
| with: | |
| architecture: 'x64' # optional x64 or x86. Defaults to x64 if not specified | |
| python-version: '3.11' |
While in builds.ifcopenshell ci's we do:
IfcOpenShell/.github/workflows/build_win.yml
Lines 14 to 18 in 718254f
| steps: | |
| - name: Checkout Repository | |
| uses: actions/checkout@v3 | |
| with: | |
| submodules: recursive |
While those modules are not very important for Bonsai, until we start using them there, I've also found that our pypi build is missing them for the same reason:
Current build from https://pypi.org/project/ifcopenshell/#files:
Repo (https://github.com/IfcOpenShell/IfcOpenShell/tree/v0.8.0/src/ifcopenshell-python/ifcopenshell):
I'll add those submodules to the related workflows, but those modules will start appearing in our pypi builds only in 0.8.3+
Attachments
No response
Debug and Error Output

