[codex] v2.5.0 operational robustness and observability#26
Merged
Conversation
…, noise budget, update docs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16160244cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR advances SentinelID to v2.5.0 and focuses on operational robustness and observability during release validation.
The release line is now aligned across the release-critical docs, desktop package/config metadata, pilot evidence target, and cloud API metadata. The release gate also became stricter about version drift by checking the desktop package/config surfaces in addition to the existing docs and cloud metadata.
The main runtime addition is a dedicated invariant smoke script that validates loopback binding, edge bearer enforcement, cloud admin token enforcement, and support-bundle endpoint behavior. It writes a machine-readable JSON report, release-check publishes that report into
output/release/, and the evidence pack now includes it.The main diagnostics addition is a desktop warning-noise budget for Rust/Tauri build output. Release-check now captures desktop cargo output into a log, parses warning counts into a JSON summary, enforces
DESKTOP_WARNING_BUDGET, and surfaces the top warning sources directly. This reduces noise during normal runs while making failures easier to triage.Why this change
Release-check was already comprehensive, but it still left some failure modes too implicit:
This PR closes those gaps and makes the release path more diagnosable for both local operators and CI parity runs.
Implementation details
v2.5.0across changelog, runbook, release docs, pilot target, Make help banner, desktop package/config metadata, and cloud metadatascripts/release/check_version_consistency.shto cover:apps/desktop/package.jsonapps/desktop/package-lock.jsonapps/desktop/tauri.conf.jsonapps/desktop/src-tauri/tauri.conf.jsonapps/desktop/src-tauri/tauri.dev.conf.jsonscripts/release/build_pilot_evidence_index.shscripts/check_invariants.pyscripts/ci/check_desktop_warning_budget.pyscripts/release/checklist.shscripts/release/build_evidence_pack.shapps/cloud/tests/test_release_observability_scripts.pyValidation
Locally verified:
./scripts/release/check_version_consistency.shmake check-invariantsmake demo-verifymake release-checkapps/cloud/tests/test_release_observability_scripts.pyRelease evidence from the successful local gate includes:
invariant_report.jsondesktop_warning_budget.jsonreliability_slo.jsonsupport_bundle_latest.tar.gzbench_edge_latest.json