fix: persist contentHash on append and normalize response casing#16
Merged
fix: persist contentHash on append and normalize response casing#16
Conversation
… casing AppendAsync's mutation path (ReplaceItemAsync) was writing the merged document without recomputing ContentHash/ContentLength, causing those fields to disappear from Cosmos after any second-or-later append. This broke CompareDocument for any document that had been appended to. All anonymous-object response serializations now use explicit lowercase property names so System.Text.Json emits camelCase matching the BrainDocument model's [JsonPropertyName] attributes. Also adds contentHash to AppendDocument and UpsertDocumentChunked responses. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppendAsyncmutation path (append-to-existing) now computesContentHashandContentLengthon the merged document beforeReplaceItemAsync. Previously these fields were dropped, breakingCompareDocumentfor any appended-to document.key = saved.Key) soSystem.Text.Jsonemits camelCase matchingBrainDocument's[JsonPropertyName]attributes.contentHashadded toAppendDocumentandUpsertDocumentChunkedresponses.GetDocumentMetadata,ListDocuments, andSearchDocumentsfor consistency.Test plan
AppendDocumentto a new key →GetDocumentreturnscontentHash+contentLengthAppendDocumentto the same key again →GetDocumentstill returns correctcontentHash+contentLengthCompareDocumentagainst an appended-to doc with matching content →match: trueAppendDocumentresponse body uses camelCase and includescontentHashUpsertDocumentChunkedfinalize response uses camelCase and includescontentHashListDocuments,SearchDocuments,GetDocumentMetadataresponses use camelCase🤖 Generated with Claude Code