Skip to content

Create date & time picker form samples-master#2703

Merged
kdinev merged 18 commits intomasterfrom
PMiteva/date-time-picker-samples-master
Jun 15, 2021
Merged

Create date & time picker form samples-master#2703
kdinev merged 18 commits intomasterfrom
PMiteva/date-time-picker-samples-master

Conversation

@PlamenaMiteva
Copy link
Copy Markdown
Contributor

@PlamenaMiteva PlamenaMiteva commented Jun 4, 2021

Closes #2660

The following samples show how the date & time picker could act as a Date & Time Picker Component:

  • date and time picker using ngModel bound to one and the same date object in a template-driven form

  • date and time picker in a reactive form with a possible workaround that updates the value of the date picker on time picker value change and vice versa

@StefanIvanov
Copy link
Copy Markdown

@PlamenaMiteva please update the samples accordingly:

set the total form width to 400px
make the date picker 55% and time picker 45% with 16px in between

Also show just once the date object and display it in the paragraph with form validity like so:

Screenshot 2021-06-07 at 14 34 03

@StefanIvanov StefanIvanov self-requested a review June 9, 2021 09:06
StefanIvanov
StefanIvanov previously approved these changes Jun 9, 2021
@StefanIvanov StefanIvanov self-requested a review June 10, 2021 08:58
StefanIvanov
StefanIvanov previously approved these changes Jun 10, 2021
jackofdiamond5
jackofdiamond5 previously approved these changes Jun 11, 2021
Lipata
Lipata previously requested changes Jun 11, 2021
Copy link
Copy Markdown
Contributor

@Lipata Lipata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StackBlitz and CodeSandBox samples are nor working

@damyanpetev damyanpetev dismissed Lipata’s stale review June 14, 2021 12:42

stackblitz config fixed

@kdinev kdinev merged commit d417dfe into master Jun 15, 2021
@kdinev kdinev deleted the PMiteva/date-time-picker-samples-master branch June 15, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Date & Time Picker Sample

8 participants