Skip to content

Ttonev autosizing sample#3069

Merged
ChronosSF merged 6 commits intovNextfrom
ttonev-autosizingSample
Aug 19, 2022
Merged

Ttonev autosizing sample#3069
ChronosSF merged 6 commits intovNextfrom
ttonev-autosizingSample

Conversation

@tishko0
Copy link
Copy Markdown
Contributor

@tishko0 tishko0 commented Aug 17, 2022

closes #3067
Added samples for the new autoresize feature of the grids

@tishko0 tishko0 changed the base branch from master to vNext August 17, 2022 10:13
@tishko0
Copy link
Copy Markdown
Contributor Author

tishko0 commented Aug 17, 2022

The current version of vNext does not have the latest changes as this feature is introduced at 14.1, so the samples will not work yet. There seems to be a style missing from the latest build that is not yet into vNext, so I suppose some migrations will need to be done before the samples can be tested in this state.

@dkamburov
Copy link
Copy Markdown
Contributor

@tishko0 please resolve the conflicts

@dkamburov
Copy link
Copy Markdown
Contributor

@tishko0 The build fails, there must be an issue with the merge

Comment thread live-editing/configs/app-dv-configs/DVHierarchicalGridConfig.ts
@dkamburov
Copy link
Copy Markdown
Contributor

@tishko0 currently hierarchical grid sample is not loading and throwing an error.

@tishko0
Copy link
Copy Markdown
Contributor Author

tishko0 commented Aug 18, 2022

fixed now

@ChronosSF
Copy link
Copy Markdown
Member

@tishko0 - some observations and requests

  1. always format the files before committing
  2. remove things copy pasted from other samples that are not needed
  3. make the samples focus on the feature shown, remove the fluff coming from samples you derive yours from
  4. always make sure that npm run start:live-editing passes
  5. don't include LOB stuff if not needed (such as the sparkline in the hierarchical sample)
  6. test your samples with a running docfx app so that you can see if your generation configs work (by clicking on the stackblitz button)
  7. ideally make a self-review on the PR . You were deleting two routes for two other samples that made live-editing to fail

@ChronosSF ChronosSF merged commit a39bf3f into vNext Aug 19, 2022
@ChronosSF ChronosSF deleted the ttonev-autosizingSample branch August 19, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants