Skip to content

refactor(samples): changes with igniteui-theming#3077

Merged
simeonoff merged 24 commits intovNextfrom
simeonoff/igniteui-theming
Oct 31, 2022
Merged

refactor(samples): changes with igniteui-theming#3077
simeonoff merged 24 commits intovNextfrom
simeonoff/igniteui-theming

Conversation

@simeonoff
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/_variables.scss
@simeonoff simeonoff linked an issue Aug 29, 2022 that may be closed by this pull request
@didimmova
Copy link
Copy Markdown
Contributor

  • In shadows/card-sample-shadow.scss file the elevations function is being used and it doesn’t exist anymore in the theming package. Are we going to create a function like this there so we can keep using it?

  • No surface color in palettes in app/theming/styles files

@simeonoff
Copy link
Copy Markdown
Collaborator Author

@didimmova All version references here need to be updated from 14.2.x. to 15.0.x.

@didimmova
Copy link
Copy Markdown
Contributor

Fix the custom elevations color sample in shadows/card-sample-shadow.scss file

@simeonoff
Copy link
Copy Markdown
Collaborator Author

Fix the custom elevations color sample in shadows/card-sample-shadow.scss file

Done.

@simeonoff simeonoff requested a review from didimmova October 18, 2022 13:51
didimmova
didimmova previously approved these changes Oct 18, 2022
Comment thread src/app/data-entries/dropdown/dropdown-menu/dropdown-menu.component.scss Outdated
Comment thread src/app/grid/grid-keyboardnav-guide-sample/grid-keyboardnav-sample.component.scss Outdated
Comment thread src/app/interactions/drag-drop/kanban-sample/kanban-sample.component.scss Outdated
Comment thread src/app/lists/list/list-sample-8/list-sample-8.component.scss Outdated
@simeonoff simeonoff merged commit 9cd07a2 into vNext Oct 31, 2022
@simeonoff simeonoff deleted the simeonoff/igniteui-theming branch October 31, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Themes] - Update samples for 15.0.x with igniteui-themeing

4 participants