Skip to content

feat(list): adding list item selection sample#3087

Merged
ChronosSF merged 11 commits intovNextfrom
list-item-selection
Sep 12, 2022
Merged

feat(list): adding list item selection sample#3087
ChronosSF merged 11 commits intovNextfrom
list-item-selection

Conversation

@kdinev
Copy link
Copy Markdown
Member

@kdinev kdinev commented Sep 8, 2022

Adding a new sample showing how to implement selected styles to list items.

@kdinev kdinev added the list label Sep 8, 2022
Copy link
Copy Markdown
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no config added for this sample in live-editing/configs/ListConfigGenerator.ts

Comment thread src/app/lists/list/list-item-selection/list-item-selection.component.html Outdated
Comment thread src/app/lists/list/list-item-selection/list-item-selection.component.ts Outdated
@wnvko wnvko self-requested a review September 8, 2022 14:53
wnvko
wnvko previously approved these changes Sep 8, 2022
wnvko
wnvko previously approved these changes Sep 9, 2022
@kdinev kdinev requested review from wnvko and removed request for MonikaKirkova September 9, 2022 13:18
Comment thread live-editing/configs/ListConfigGenerator.ts Outdated
Comment thread src/app/lists/list/list-item-selection/list-item-selection.component.ts Outdated
@kdinev kdinev requested a review from wnvko September 12, 2022 08:52
Comment thread live-editing/configs/ListConfigGenerator.ts Outdated
Co-authored-by: Milko Venkov <milko.venkov@gmail.com>
wnvko
wnvko previously approved these changes Sep 12, 2022
@kdinev
Copy link
Copy Markdown
Member Author

kdinev commented Sep 12, 2022

@wnvko Have you also tested it?

@ChronosSF ChronosSF self-assigned this Sep 12, 2022
@ChronosSF ChronosSF merged commit f9564fb into vNext Sep 12, 2022
@ChronosSF ChronosSF deleted the list-item-selection branch September 12, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants