Skip to content

Remove some code from the old API. Fix tree grid cross-field cells wi…#3091

Merged
dkamburov merged 7 commits intovNextfrom
mdragnev/validation-touches
Sep 13, 2022
Merged

Remove some code from the old API. Fix tree grid cross-field cells wi…#3091
dkamburov merged 7 commits intovNextfrom
mdragnev/validation-touches

Conversation

@mddragnev
Copy link
Copy Markdown
Member

…th select component. Some more issues

dkamburov
dkamburov previously approved these changes Sep 12, 2022
@MayaKirova
Copy link
Copy Markdown
Contributor

MayaKirova commented Sep 12, 2022

@mddragnev

  1. The phoneFormat validator at hierarchical-grid-validator-service-extended.component.html never seems to be invoked so the error never shows.

  2. I see that a new import was added at: https://github.com/IgniteUI/igniteui-angular-samples/pull/3091/files#diff-508cbce15cb0b9ae2284501fcea09c595e5df582c7030534f1b5a907122b4cf6R236

    Same import should be added in the Stackblitz config as well. Otherwise it will not work.

@mddragnev
Copy link
Copy Markdown
Member Author

mddragnev commented Sep 12, 2022

@MayaKirova

  1. For the first question it does invoke but you need to put a symbol different than a digit. For example try adding 'abv' in the end.
  2. I have added it.

],
appModuleConfig: new AppModuleConfig({
imports: ['HierarchicalGridValidatorServiceExtendedComponent', 'IgxHierarchicalGridModule', 'IgxPreventDocumentScrollModule'],
imports: ['HierarchicalGridValidatorServiceExtendedComponent', 'IgxHierarchicalGridModule', 'IgxPreventDocumentScrollModule', 'ReactiveFormsModule'],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be added in the TreeGridConfigGenerator for the cross-field validation sample config?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I have misplaced it. Gonna fix that now.

@MayaKirova
Copy link
Copy Markdown
Contributor

@mddragnev

  1. Seems to have been an issue on my side. Works ok now.
  2. Seems ok but shouldn't it be in the tree grid config? Since the modules for the tree grid were the ones updated.

@mddragnev
Copy link
Copy Markdown
Member Author

@mddragnev

  1. Seems to have been an issue on my side. Works ok now.
  2. Seems ok but shouldn't it be in the tree grid config? Since the modules for the tree grid were the ones updated.

I tested it now. Should be working.

@dkamburov dkamburov merged commit 11d7bba into vNext Sep 13, 2022
@dkamburov dkamburov deleted the mdragnev/validation-touches branch September 13, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants