Remove some code from the old API. Fix tree grid cross-field cells wi…#3091
Merged
Remove some code from the old API. Fix tree grid cross-field cells wi…#3091
Conversation
…th select component. Some more issues
dkamburov
previously approved these changes
Sep 12, 2022
Contributor
|
Member
Author
|
MayaKirova
reviewed
Sep 13, 2022
| ], | ||
| appModuleConfig: new AppModuleConfig({ | ||
| imports: ['HierarchicalGridValidatorServiceExtendedComponent', 'IgxHierarchicalGridModule', 'IgxPreventDocumentScrollModule'], | ||
| imports: ['HierarchicalGridValidatorServiceExtendedComponent', 'IgxHierarchicalGridModule', 'IgxPreventDocumentScrollModule', 'ReactiveFormsModule'], |
Contributor
There was a problem hiding this comment.
Shouldn't this be added in the TreeGridConfigGenerator for the cross-field validation sample config?
Member
Author
There was a problem hiding this comment.
Yup, I have misplaced it. Gonna fix that now.
Contributor
|
Member
Author
I tested it now. Should be working. |
MayaKirova
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th select component. Some more issues