Skip to content

feat(checkbox): change indeterminate fluent checkbox look #11253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 22, 2022
Merged

feat(checkbox): change indeterminate fluent checkbox look #11253

merged 5 commits into from
Mar 22, 2022

Conversation

@didimmova
Copy link
Contributor

@didimmova didimmova commented Mar 18, 2022

Closes #11199

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova didimmova linked an issue Mar 18, 2022 that may be closed by this pull request
Update checkbox styles for Fluent theme #11199
Closed
StefanIvanov
StefanIvanov previously approved these changes Mar 21, 2022
View reviewed changes
simeonoff
simeonoff requested changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the rem function when declaring pixel values.

@didimmova didimmova requested a review from simeonoff March 22, 2022 12:17
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 22, 2022
@simeonoff simeonoff merged commit f530543 into 13.1.x Mar 22, 2022
@simeonoff simeonoff deleted the didimmova/update-fluent-checkbox branch March 22, 2022 13:07
This was referenced Mar 29, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 11, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

+1 more reviewer

@StefanIvanov StefanIvanov StefanIvanov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

checkbox fluent-theme ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update checkbox styles for Fluent theme

4 participants

@didimmova @StefanIvanov @simeonoff