fix(charts): negative brushes color#11722
Merged
Conversation
simeonoff
approved these changes
Jun 16, 2022
simeonoff
previously approved these changes
Jun 16, 2022
damyanpetev
added
💥 status: in-test
damyanpetev
requested changes
Jun 17, 2022
| /// @property {List} outlines [series] - Defines the palette from which automatically assigned series outline colors are selected. | ||
| /// @property {List} marker-outlines [series] - Defines the palette from which automatically assigned series marker outline colors are selected. | ||
| /// @property {List} negative-outlines [series] - Defines the brushes used for drawing negative elements in a chart type with contextual coloring, such as Waterfall. | ||
| /// @property {Color} marker-outlines [hsl(347, 82%, 64%)] - Defines the palette from which automatically assigned series marker outline colors are selected. |
Member
There was a problem hiding this comment.
This is marker outlines, guessing it should be on negative brushes?
| /// @property {List} marker-outlines [series] - Defines the palette from which automatically assigned series marker outline colors are selected. | ||
| /// @property {List} negative-outlines [series] - Defines the brushes used for drawing negative elements in a chart type with contextual coloring, such as Waterfall. | ||
| /// @property {Color} marker-outlines [hsl(347, 82%, 64%)] - Defines the palette from which automatically assigned series marker outline colors are selected. | ||
| /// @property {Color} negative-outlines [hsl(347, 82%, 64%)] - Defines the brushes used for drawing negative elements in a chart type with contextual coloring, such as Waterfall. |
Member
There was a problem hiding this comment.
Also not sure this affects your SASS docs generation, but if it does - negative brushes/outlines (as the names suggest) are still lists. We're just setting a singular value in them by default, right?
damyanpetev
added
✅ status: verified
simeonoff
approved these changes
Jun 20, 2022
simeonoff
pushed a commit
that referenced
this pull request
Jun 20, 2022
This reverts commit c6c0c9f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11662
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)