refactor(elements): component theme cb to update name/prefix and selector #12974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanpetev
commented
May 4, 2023
|
|
||
| @include igx.core(); | ||
| @include igx.typography($font-family: igx.$bootstrap-typeface, $type-scale: igx.$bootstrap-type-scale); | ||
| @include igx.bootstrap-light-theme($palette: $palette, $exclude: vars.$unused-themes); |
Member
Author
There was a problem hiding this comment.
Only concern from moving away from using bootstrap-light-theme and so on - that mixin seems to do something extra, rather than using the light-bootstrap-palette directly for some reason:
Kinda odd
damyanpetev
force-pushed
the
dpetev/elements-theme-shenanigans
branch
from
0e8daf2 to
318fb48
Compare
damyanpetev
force-pushed
the
dpetev/elements-theme-shenanigans
branch
from
318fb48 to
8e0f62a
Compare
This was referenced May 23, 2023
…ements-theme-shenanigans
…ements-theme-shenanigans
damyanpetev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Update the component global CSS var prefixes when exposed as
igc-element in a mostly automated way without disturbing the base source too much. Could also help with adjusting selectors of exposed components instead of stacking them all in each component's theme as already done in the target branch.I've checked and as far as I see there are no references to the name of the theme and the only usage for the theme name is for CSS vars:
https://github.com/IgniteUI/igniteui-theming/blob/733926ee432cb66efdbe1045ddac5c51ea1bb071/sass/themes/_mixins.scss#L63
Also fixes #12956
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)