Skip to content

fix(igxGrid): Fix issue with group expanding container. #14512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix(igxGrid): Fix issue with group expanding container. #14512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b21a073
fix(igxGrid): Fix issue with group expanding container.
Jul 10, 2024
8643524
chore(*): Add a column group with auto size test.
Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { ISortingExpression, SortingDirection } from '../../data-operations/sort
import { GRID_SCROLL_CLASS } from '../../test-utils/grid-functions.spec';
import { AsyncPipe, NgFor, NgIf } from '@angular/common';
import { IgxPaginatorComponent, IgxPaginatorContentDirective } from '../../paginator/paginator.component';
import { IGridRowEventArgs, IgxGridFooterComponent, IgxGridRow, IgxGroupByRow, IgxSummaryRow } from '../public_api';
import { IGridRowEventArgs, IgxColumnGroupComponent, IgxGridFooterComponent, IgxGridRow, IgxGroupByRow, IgxSummaryRow } from '../public_api';
import { getComponentSize } from '../../core/utils';


Expand Down Expand Up @@ -1896,6 +1896,20 @@ describe('IgxGrid Component Tests #grid', () => {

expect(calcWidth).not.toBe(80);
});

it('should correctly autosize column headers inside column groups.', async () => {
const fix = TestBed.createComponent(IgxGridColumnHeaderInGroupAutoSizeComponent);
const grid = fix.componentInstance.grid;
grid.data = [{field1: "Test"}];

//waiting for reqeustAnimationFrame to finish
fix.detectChanges();
await wait(17);
fix.detectChanges();

const calcWidth = parseInt(grid.getColumnByName("field1").calcWidth);
expect(calcWidth).toBe(126);
});
});

describe('IgxGrid - API methods', () => {
Expand Down Expand Up @@ -2962,6 +2976,36 @@ export class IgxGridColumnHeaderAutoSizeComponent {

}

@Component({
template: `
<igx-grid #grid>
<igx-column-group>
<igx-column
field="field1"
header="Field 1 Header"
width="auto"
></igx-column>
<igx-column
field="field2"
header="Field 2 Header"
width="auto"
></igx-column>
<igx-column
field="field3"
header="Field 3 Header"
width="auto"
></igx-column>
</igx-column-group>
</igx-grid>`,
standalone: true,
imports: [IgxGridComponent, IgxColumnComponent, IgxColumnGroupComponent]

})
export class IgxGridColumnHeaderInGroupAutoSizeComponent {
@ViewChild('grid', { read: IgxGridComponent, static: true })
public grid: IgxGridComponent;
}

@Component({
template: `<igx-grid #grid [data]="data" [width]="'500px'" (columnInit)="initColumns($event)">
<igx-column *ngFor="let col of columns" [field]="col.key" [header]="col.key" [dataType]="col.dataType">
Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/grids/headers/grid-header-group.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
[ngClass]="child.headerGroupClasses"
[ngStyle]="child.headerGroupStyles | igxHeaderGroupStyle:child:grid.pipeTrigger"
[column]="child"
[style.min-width]="child.calcWidth | igxHeaderGroupWidth:grid.defaultHeaderGroupMinWidth:grid.hasColumnLayouts"
[style.flex-basis]="child.calcWidth | igxHeaderGroupWidth:grid.defaultHeaderGroupMinWidth:grid.hasColumnLayouts">
[style.min-width]="child.resolvedWidth | igxHeaderGroupWidth:grid.defaultHeaderGroupMinWidth:grid.hasColumnLayouts"
[style.flex-basis]="child.resolvedWidth | igxHeaderGroupWidth:grid.defaultHeaderGroupMinWidth:grid.hasColumnLayouts">
</igx-grid-header-group>
</ng-container>
</div>
Expand Down