Skip to content

fix(elements): inject grid instead of grid api in state component #14594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Mass Merge 18.1.x to master
merged 3 commits into from
Jul 30, 2024
Merged

fix(elements): inject grid instead of grid api in state component #14594

merged 3 commits into from
Jul 30, 2024

Conversation

@mddragnev
Copy link
Member

Closes #14593

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev changed the title fix(state): inject grid instead of grid api in elements state comp fix(elements): inject grid instead of grid api in state component Jul 26, 2024
@damyanpetev damyanpetev changed the base branch from master to 18.1.x July 26, 2024 14:51
@mddragnev mddragnev force-pushed the mdragnev/fix-14593 branch from 26c8fdb to d10c80e Compare July 26, 2024 15:11
@damyanpetev damyanpetev added the squash-merge Merge PR with "Squash and Merge" option label Jul 26, 2024
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 30, 2024
@damyanpetev damyanpetev merged commit ecb0e40 into 18.1.x Jul 30, 2024
@damyanpetev damyanpetev deleted the mdragnev/fix-14593 branch July 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

Assignees

@dkamburov dkamburov

@tishko0 tishko0

Labels

💠 grid: elements grid: state-persistence squash-merge Merge PR with "Squash and Merge" option version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ELEMENTS] State persistence does not work in pivot grid

4 participants

@mddragnev @damyanpetev @dkamburov @tishko0