refactor(grids): move watermark register #14750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13562
While the use of the
@__PURE__notation is valid on a stand-alone expression call (I imagined it wouldn't be, but see https://github.com/javascript-compiler-hints/compiler-notations-spec/blob/main/pure-notation-spec.md, also https://esbuild.github.io/api/#pure) in this scenario it doesn't quite work.The register is actually side-effectful to begin with and since this is a top level expression that doesn't have it's supposed return value used or exported the notation basically means permanent tree-shake and deletes the register.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)