Skip to content

Conversation

@damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Sep 12, 2024

Related to #13562

While the use of the @__PURE__ notation is valid on a stand-alone expression call (I imagined it wouldn't be, but see https://github.com/javascript-compiler-hints/compiler-notations-spec/blob/main/pure-notation-spec.md, also https://esbuild.github.io/api/#pure) in this scenario it doesn't quite work.
The register is actually side-effectful to begin with and since this is a top level expression that doesn't have it's supposed return value used or exported the notation basically means permanent tree-shake and deletes the register.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev merged commit f34d8f7 into 18.1.x Sep 16, 2024
4 checks passed
@damyanpetev damyanpetev deleted the dpetev/grid-watermark-register-18.1 branch September 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants