Skip to content

Conversation

@damyanpetev
Copy link
Member

Closes #14918

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev marked this pull request as ready for review October 21, 2024 16:27
@damyanpetev damyanpetev marked this pull request as draft October 21, 2024 16:27
@damyanpetev damyanpetev force-pushed the dpetev/date-picker-kb-nav branch from b2cde79 to 0bc01d7 Compare October 22, 2024 06:15
@damyanpetev damyanpetev added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 22, 2024
@damyanpetev damyanpetev requested a review from ChronosSF October 22, 2024 08:30
@damyanpetev damyanpetev marked this pull request as ready for review October 22, 2024 08:30
@gedinakova
Copy link
Contributor

gedinakova commented Oct 22, 2024

@damyanpetev Query Builder/ Advanced filtering
Not sure if this is the same issue, but if after opening the picker, no value is selected but rather press Escape or click outside, the focus shifts to the parent component.
Works fine in the time picker, though and in the filter row.
screen-capture (1).webm

@damyanpetev
Copy link
Member Author

@damyanpetev Query Builder/ Advanced filtering Not sure if this is the same issue, but if after opening the picker, no value is selected but rather press Escape or click outside, the focus shifts to the parent component. Works fine in the time picker, though and in the filter row. screen-capture (1).webm

@gedinakova Can only assume the keystrokes in the recording, but can't really reproduce and guessing you didn't hit Enter to actually select something, just navigated around. At least it works when I try it.

@gedinakova
Copy link
Contributor

@damyanpetev

  1. In query builder demo, start a condition for Date Created field
  2. Select a filter, click to open the date picker
  3. Press "Esc" and check the focus

Expected result: The focus to be returned to the input.
Actual result: The focus is shifted to the body.

@damyanpetev
Copy link
Member Author

@damyanpetev

  1. In query builder demo, start a condition for Date Created field
  2. Select a filter, click to open the date picker
  3. Press "Esc" and check the focus

Expected result: The focus to be returned to the input. Actual result: The focus is shifted to the body.

Hey, that's another one 🥴 However, looking at the code, that's not related to the calendar refactor anymore, actually not sure how it could've worked before at all. Will see if there's an easy fix.

@ChronosSF ChronosSF self-assigned this Oct 23, 2024
@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 23, 2024
@gedinakova gedinakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 24, 2024
@ChronosSF ChronosSF merged commit 7b220b9 into master Oct 24, 2024
5 checks passed
@ChronosSF ChronosSF deleted the dpetev/date-picker-kb-nav branch October 24, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date Picker KB navigation with calendar doesn't work

3 participants