Skip to content

fix(esf): prevent error for untyped non-string columns when filtering grid #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

fix(esf): prevent error for untyped non-string columns when filtering grid #15454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54793a7
fix(esf): check for untyped non-string columns when filtering grid th…
teodosiah Mar 5, 2025
785d852
Merge branch '18.2.x' into thristodorova/fix-15448-18.2.x
gedinakova Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-filtering.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ export class IgxGridExcelStyleFilteringComponent extends BaseFilteringComponent
const lowerCaseFilterValues = new Set(Array.from(expr.expression.searchVal).map((value: string) => value.toLowerCase()));

this.grid.data.forEach(item => {
if (lowerCaseFilterValues.has(item[this.column.field]?.toLowerCase())) {
if (typeof item[this.column.field] === "string" && lowerCaseFilterValues.has(item[this.column.field]?.toLowerCase())) {
expr.expression.searchVal.add(item[this.column.field]);
}
});
Expand Down
24 changes: 24 additions & 0 deletions projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-filtering.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { GridFunctions } from '../../test-utils/grid-functions.spec';
import { UIInteractions } from '../../test-utils/ui-interactions.spec';
import { SampleTestData } from '../../test-utils/sample-test-data.spec';
import { By } from '@angular/platform-browser';
import { GridColumnDataType } from '../../data-operations/data-util';

const IGX_CHECKBOX_LABEL = '.igx-checkbox__label';

Expand Down Expand Up @@ -751,6 +752,29 @@ describe('IgxTreeGrid - Filtering actions #tGrid', () => {
emptyTextEl = searchComponent.querySelector('.igx-excel-filter__empty');
expect(emptyTextEl.innerText).toEqual('No matches');
}));

it('Should not throw console error when number column with dataType string is filtered.', fakeAsync(() => {
tGrid.columns[0].dataType = GridColumnDataType.String;
fix.detectChanges();
spyOn(console, 'error');

GridFunctions.clickExcelFilterIcon(fix, 'ID');
fix.detectChanges();
tick();

const excelMenu = GridFunctions.getExcelStyleFilteringComponent(fix, 'igx-tree-grid');
const checkboxes: any[] = Array.from(GridFunctions.getExcelStyleFilteringCheckboxes(fix, excelMenu, 'igx-tree-grid'));

checkboxes[2].click();
tick();
fix.detectChanges();

GridFunctions.clickApplyExcelStyleFiltering(fix, null, 'igx-tree-grid');
fix.detectChanges();
tick();

expect(console.error).not.toHaveBeenCalled();
}));
});

describe('Tree grid ESF templates', () => {
Expand Down
Loading