fix(grid): Cancel endEdit if there is no active editing #15996
Conversation
dkamburov
added
grid: cell-editing
grid
angular
❌ status: awaiting-test
| detect(); | ||
| // Invoke endEdit() to make sure if no editing is going on, | ||
| // the cell activation shouldn't be lost (https://infragistics.visualstudio.com/Indigo_Platform/_workitems/edit/37933) | ||
| grid.endEdit(true, null); |
There was a problem hiding this comment.
IMO it would be better if this was a separate test rather than modifying an existing basic one. If we automate everything related to a certain feature in the same test it will soon become too convoluted to read and maintain.
There was a problem hiding this comment.
Yeah, that's true, but it's a single line and we are at a stage were we have too many test and we should be careful when adding new ones, also Damyan suggested adding this to an already existing one.
There was a problem hiding this comment.
Could you elaborate on what you mean by too many tests? I'm not aware of there being an issue with adding new ones.
There was a problem hiding this comment.
Mainly because of the disconnects, I know there is another reason for them, but the bigger amount of the tests is not helping.
tishko0
added
✅ status: verified
5 participants
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)