Skip to content

fix[(alendar): fix date styles and formating #16618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
desig9stein wants to merge 5 commits into
base: master
Choose a base branch
from
+15 −1
Open

fix[(alendar): fix date styles and formating #16618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a48098f
fix(calendar): ensure text in calendar components does not wrap unexp…
desig9stein Dec 8, 2025
2f8d7ae
fix(calendar): update days formatting logic to extract day part and a…
desig9stein Dec 9, 2025
bdd8489
Merge branch 'master' into mpopov/fix-calendar-date-localization-styles
desig9stein Dec 9, 2025
303cede
fix(calendar): correct locale codes in sample for Chinese regions
desig9stein Dec 9, 2025
6bd8cf0
Merge branch 'master' into mpopov/fix-calendar-date-localization-styles
desig9stein Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion projects/igniteui-angular/calendar/src/calendar/days-view/days-view.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,8 @@ export class IgxDaysViewComponent extends IgxCalendarBaseDirective implements Af
*/
public formattedDate(value: Date): string {
if (this.formatViews.day) {
return this.formatterDay.format(value);
const dateParts = this.formatterDay.formatToParts(value);
return dateParts.find(part => part.type === 'day')?.value ?? value.getDate().toString();
Comment on lines +449 to +450
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic now extracts only the 'day' part from the formatted date, which changes the behavior from returning a fully formatted date to returning just the day number. This could be a breaking change if consumers expect the full formatted output. Consider whether this aligns with the intended fix or if a new configuration option is needed.

Suggested change
const dateParts = this.formatterDay.formatToParts(value);
return dateParts.find(part => part.type === 'day')?.value ?? value.getDate().toString();
return this.formatterDay.format(value);

Copilot uses AI. Check for mistakes.
}

return `${value.getDate()}`;
Expand Down
2 changes: 2 additions & 0 deletions projects/igniteui-angular/core/src/core/styles/components/calendar/_calendar-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2516,6 +2516,7 @@
letter-spacing: sizable(var(--ig-body-2-letter-spacing), var(--ig-body-2-letter-spacing), var(--ig-body-1-letter-spacing));
text-transform: sizable(var(--ig-body-2-text-transform), var(--ig-body-2-text-transform), var(--ig-body-1-text-transform));
margin: 0;
white-space: nowrap;
}
}

Expand All @@ -2528,6 +2529,7 @@
letter-spacing: sizable(var(--ig-body-2-letter-spacing), var(--ig-body-2-letter-spacing), var(--ig-body-1-letter-spacing));
text-transform: sizable(var(--ig-body-2-text-transform), var(--ig-body-2-text-transform), var(--ig-body-1-text-transform));
margin: 0;
white-space: nowrap;
}
}
}
11 changes: 11 additions & 0 deletions src/app/calendar/calendar.sample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
DateRange,
DateRangeDescriptor,
DateRangeType,
IFormattingViews,
} from 'igniteui-angular';
import {
Properties,
Expand Down Expand Up @@ -62,6 +63,12 @@ export class CalendarSampleComponent implements OnInit {
year: 'numeric',
};

protected formatViews: IFormattingViews = {
day: true,
month: true,
year: true
};
Comment on lines +66 to +70
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added formatViews property lacks documentation explaining its purpose and how it affects calendar behavior. Add a JSDoc comment describing what this configuration controls.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@desig9stein desig9stein Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't add documentation for the demo samples


public panelConfig: PropertyPanelConfig = {
locale: {
label: 'Change Locale',
Expand All @@ -87,6 +94,10 @@ export class CalendarSampleComponent implements OnInit {
{
value: 'ja-JP',
label: 'JP'
},
{
value: 'zh-CN',
label: 'CN'
}
],
defaultValue: 'en-US'
Expand Down
Loading