Skip to content

Conversation

@MayaKirova
Copy link
Contributor

Closes #5288

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova force-pushed the mkirova/fix-5288-8.0.x branch from 02fd506 to 667e7e0 Compare July 12, 2019 10:50
…at change the total grid width (row selectors, expansion indicators etc.).
@3phase 3phase added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 18, 2019
@3phase
Copy link
Contributor

3phase commented Jul 18, 2019

When setting igx-grid's width property to null, space is being added. That bug doesn't persist below 8.0.x and in case width is set to a value, for instance 100%, as well.
The bug fixes itself automatically when a column resize is made.

MayaKirova and others added 2 commits July 18, 2019 15:17
…nto account when calculating virtualization width as it should be equal to the sum of column widths.
@MayaKirova MayaKirova removed the 💥 status: in-test PRs currently being tested label Jul 18, 2019
@MayaKirova
Copy link
Contributor Author

@3phase Please re-test.

@3phase 3phase added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 19, 2019
@3phase
Copy link
Contributor

3phase commented Jul 19, 2019

The bug persists on versions 8.0.x and above.
The tested samples are Grid Filter Template and Grid Column Resizing.
The first tested sample breaks on the last column and appends space for almost one full-size column at the end. When one attempts to resize a random column, the breaks are getting fixed and the behavior is as expected.
The second tested sample adds y-scrollbar but on resize hides it.
I'm attaching screenshots of both samples while broken.

Grid Filter Template:
image

Grid Column Resize:
image

@MayaKirova
Copy link
Contributor Author

@3phase Please re-test again :)

@3phase 3phase added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 19, 2019
3phase
3phase previously approved these changes Jul 19, 2019
Copy link
Contributor

@3phase 3phase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now 👀

@ChronosSF ChronosSF requested a review from rkaraivanov July 23, 2019 12:52
ChronosSF
ChronosSF previously approved these changes Jul 23, 2019
MKirova added 2 commits July 31, 2019 18:36
…dings so that grid will expact based on content. In case width is null and column width in % then set width to min width explicitly.
@MayaKirova
Copy link
Contributor Author

MayaKirova commented Jul 31, 2019

@ChronosSF

  • CellEditing sample - Content renders fine for me when width is set to null => [width]="null".

Are you perhaps setting "null" as string and not as a value, for example width='null'? Please note that in that case the resolved value will be string and we do no have explicit covertion for such scenarios.

  • Grid Selection sample - Cannot reproduce this either.
  • Percentage sample - Same.

@ChronosSF
Copy link
Member

Agree about 1. - probably didn't box the width input.

Capture

    <igx-grid #grid1 [data]="remote | async" [primaryKey]="'ProductID'"
            [rowSelectable]="selection" (onSelection)="handleRowSelection($event)"
            [width]="null" [height]="'600px'">
        <igx-column [field]="'ProductID'" [editable]="true" [width]="'80%'"></igx-column>
        <igx-column [field]="'ProductName'"></igx-column>
        <igx-column [field]="'UnitsInStock'"></igx-column>
    </igx-grid>

Capture1

<div class="sample-content">
    <div class="sample-column">
        <igx-grid [allowFiltering]="true" [data]="data" [autoGenerate]="false" displayDensity="comfortable" [width]="null" height="600px" [paging]="true" [perPage]="10">
            <igx-column field="ProductName" [pinned]="true" [movable]="true" header="Product Name" width="19%" [dataType]="'string'" [sortable]="true" [hasSummary]="false" [editable]="true" [filterable]="true" [resizable]="true">
            </igx-column>
            <igx-column field="UnitsInStock" [pinned]="false" [movable]="true"  header="Units In Stock" width="19%" [dataType]="'number'" [sortable]="true" [hasSummary]="false" [editable]="true" [filterable]="true" [resizable]="true">
            </igx-column>
            <igx-column field="OrderDate" [movable]="true" header="Order Date" width="19%" [dataType]="'date'" [sortable]="true" [hasSummary]="false" [editable]="true" [filterable]="true" [resizable]="true">
                <ng-template igxCell let-cell="cell" let-val>
                    {{val | date:'dd/MM/yyyy'}}
                </ng-template>
            </igx-column>
            <igx-column field="Discontinued" [movable]="true" [resizable]="true"  header="Discontinued" width="15%" [dataType]="'boolean'" [sortable]="false" [hasSummary]="false" [editable]="true" [filterable]="false" [resizable]="true">
            </igx-column>
            <igx-column field="ReorderLevel" header="Reorder Level" [movable]="true" [resizable]="true" [dataType]="'number'" width="19%" [sortable]="false" [hasSummary]="false" [editable]="true" >
                <ng-template igxCellEditor let-cell="cell">
                    <input type="number" [(ngModel)]="cell.value" style="color: black"/>
                </ng-template>
            </igx-column>
        </igx-grid>
    </div>
</div>

@MayaKirova MayaKirova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 1, 2019
@ChronosSF ChronosSF assigned ChronosSF and unassigned MayaKirova Aug 2, 2019
@ChronosSF ChronosSF added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 2, 2019
@ChronosSF ChronosSF requested review from ChronosSF and removed request for ChronosSF August 2, 2019 12:49
@ChronosSF ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 2, 2019
@mpavlinov mpavlinov added the squash-merge Merge PR with "Squash and Merge" option label Aug 5, 2019
@mpavlinov mpavlinov merged commit 11ac076 into 8.0.x Aug 5, 2019
@mpavlinov mpavlinov deleted the mkirova/fix-5288-8.0.x branch August 5, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: general squash-merge Merge PR with "Squash and Merge" option version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants