Skip to content

Update children collection when add or remove column in column group #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 1, 2019
Merged

Update children collection when add or remove column in column group #5846

merged 8 commits into from
Oct 1, 2019

Conversation

@nrobakova
Copy link
Contributor

@nrobakova nrobakova commented Sep 24, 2019

Closes #5837

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@nrobakova nrobakova self-assigned this Sep 24, 2019
@nrobakova nrobakova assigned ddincheva and unassigned nrobakova Sep 25, 2019
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 26, 2019
ddincheva
ddincheva previously approved these changes Sep 26, 2019
View reviewed changes
@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Sep 26, 2019
@zdrawku zdrawku changed the base branch from master to 8.2.x September 27, 2019 08:35
@zdrawku zdrawku merged commit 277862b into 8.2.x Oct 1, 2019
@zdrawku zdrawku deleted the nrobakova/fix-issue-5837 branch October 1, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrawku zdrawku zdrawku approved these changes

+1 more reviewer

@ddincheva ddincheva ddincheva left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ddincheva ddincheva

Labels

grid: general grid: multi-column-headers version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nrobakova @zdrawku @ddincheva