Skip to content

Enhance the ghostOffsetX and ghostOffsetY so they can be applied regardless of ghost or not. #5858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 4, 2019
Merged

Enhance the ghostOffsetX and ghostOffsetY so they can be applied regardless of ghost or not. #5858

merged 6 commits into from
Oct 4, 2019

Conversation

@skrustev
Copy link
Member

@skrustev skrustev commented Sep 25, 2019

Closes #5852

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev skrustev changed the title Enhance the ghostOffsetX and ghostOffsetX so they can be applied regardless of ghost or not. Enhance the ghostOffsetX and ghostOffsetY so they can be applied regardless of ghost or not. Sep 26, 2019
@zdrawku zdrawku changed the base branch from master to 8.2.x September 27, 2019 08:28
@mpavlinov mpavlinov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 1, 2019
@mpavlinov mpavlinov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 3, 2019
@zdrawku zdrawku merged commit 722dd3c into 8.2.x Oct 4, 2019
@zdrawku zdrawku deleted the SKrastev/drag-offset-8.2.x branch October 4, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MayaKirova MayaKirova MayaKirova approved these changes

@dkamburov dkamburov Awaiting requested review from dkamburov

@ChronosSF ChronosSF Awaiting requested review from ChronosSF

Assignees

@mpavlinov mpavlinov

Labels

drag-drop version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skrustev @MayaKirova @mpavlinov @zdrawku