Skip to content

Exposes verticalScrollContainer.igxForOf in a public method #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 13, 2019
Merged

Exposes verticalScrollContainer.igxForOf in a public method #5961

merged 9 commits into from
Oct 13, 2019

Conversation

@3phase
Copy link
Contributor

@3phase 3phase commented Oct 10, 2019

Closes #5069

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

MayaKirova
MayaKirova requested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@MayaKirova MayaKirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verticalScrollContainer.igxForOf is also used in many places in the navigation services. It should be changed to use dataView as well for consistency.

@3phase 3phase requested a review from MayaKirova October 10, 2019 09:38
@3phase
Copy link
Contributor Author

3phase commented Oct 10, 2019

verticalScrollContainer.igxForOf is also used in many places in the navigation services. It should be changed to use dataView as well for consistency.

I can't find any other uses than the already changed ones

MayaKirova
MayaKirova reviewed Oct 10, 2019
View reviewed changes
@3phase 3phase requested a review from MayaKirova October 10, 2019 12:38
MayaKirova
MayaKirova requested changes Oct 10, 2019
View reviewed changes
@3phase 3phase requested a review from MayaKirova October 10, 2019 12:53
@dkamburov dkamburov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 11, 2019
@kdinev kdinev changed the base branch from master to 8.2.x October 13, 2019 08:51
@kdinev kdinev merged commit b6fbbc4 into 8.2.x Oct 13, 2019
@kdinev kdinev deleted the pbozhinov/feat-5069 branch October 13, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdinev kdinev kdinev approved these changes

@MayaKirova MayaKirova MayaKirova approved these changes

@rkaraivanov rkaraivanov rkaraivanov approved these changes

Assignees

@dkamburov dkamburov

@ChronosSF ChronosSF

Labels

grid: general grid: hierarchical-grid grid: tree-grid version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@3phase @kdinev @MayaKirova @rkaraivanov @dkamburov @ChronosSF