Add missing React (igr-ts) component templates to match Web Components (igc-ts) selection#1576
Draft
Add missing React (igr-ts) component templates to match Web Components (igc-ts) selection#1576
Conversation
Add new React component templates for Avatar, Badge, and Button in the igr-ts project type. Each includes component-level and template-level index.ts, a .tsx component file, test file, and style.module.css. Update groups.json with Layouts and Data Entry & Display groups. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Add IgrButtonGroup, IgrCheckbox, and IgrChip component templates to the igr-ts React template collection, each with component registration, template configuration, TSX component, test file, and CSS module styles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
…io-group Add igr-ts templates for four new components in the Data Entry & Display group: - Icon: displays IgrIcon with home and search icons - Icon Button: displays IgrIconButton with contained variant - Input: displays IgrInput with label, placeholder, and helper text - Radio Group: displays IgrRadioGroup with IgrRadio options Each component includes index.ts, default template config, tsx component, test file, and CSS module following existing template patterns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
…down Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
…tree, banner, navbar, form, linear-progress, circular-progress, slider, ripple, and subscription-form Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/0942dde4-fc35-4382-893c-748eb6c4a830 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing Ignite UI for React (igr-ts) component templates and updates template grouping metadata so the React template catalog more closely matches the Web Components (igc-ts) selection.
Changes:
- Added new igr-ts component/template scaffolds (metadata + sample view + tests) for multiple controls (e.g., Accordion, Badge, Banner, Tree, etc.).
- Added/expanded
groups.jsonentries to include missing component groups used by the new templates. - Added a new custom template (
subscription-form) for igr-ts.
Reviewed changes
Copilot reviewed 154 out of 154 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/templates/react/igr-ts/accordion/index.ts | Adds Accordion component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/accordion/default/index.ts | Adds Accordion template metadata (id/name/group/components/packages). |
| packages/cli/templates/react/igr-ts/accordion/default/files/src/app/path/style.module.css | Adds CSS module styles for the Accordion view. |
| packages/cli/templates/react/igr-ts/accordion/default/files/src/app/path/filePrefix.tsx | Adds sample Accordion view implementation. |
| packages/cli/templates/react/igr-ts/accordion/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Accordion view. |
| packages/cli/templates/react/igr-ts/avatar/index.ts | Adds Avatar component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/avatar/default/index.ts | Adds Avatar template metadata. |
| packages/cli/templates/react/igr-ts/avatar/default/files/src/app/path/style.module.css | Adds CSS module styles for the Avatar view. |
| packages/cli/templates/react/igr-ts/avatar/default/files/src/app/path/filePrefix.tsx | Adds sample Avatar view implementation. |
| packages/cli/templates/react/igr-ts/avatar/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Avatar view. |
| packages/cli/templates/react/igr-ts/badge/index.ts | Adds Badge component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/badge/default/index.ts | Adds Badge template metadata. |
| packages/cli/templates/react/igr-ts/badge/default/files/src/app/path/style.module.css | Adds CSS module styles for the Badge view. |
| packages/cli/templates/react/igr-ts/badge/default/files/src/app/path/filePrefix.tsx | Adds sample Badge view implementation. |
| packages/cli/templates/react/igr-ts/badge/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Badge view. |
| packages/cli/templates/react/igr-ts/banner/index.ts | Adds Banner component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/banner/default/index.ts | Adds Banner template metadata. |
| packages/cli/templates/react/igr-ts/banner/default/files/src/app/path/style.module.css | Adds CSS module styles for the Banner view. |
| packages/cli/templates/react/igr-ts/banner/default/files/src/app/path/filePrefix.tsx | Adds sample Banner view implementation. |
| packages/cli/templates/react/igr-ts/banner/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Banner view. |
| packages/cli/templates/react/igr-ts/button/index.ts | Adds Button component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/button/default/index.ts | Adds Button template metadata. |
| packages/cli/templates/react/igr-ts/button/default/files/src/app/path/style.module.css | Adds CSS module styles for the Button view. |
| packages/cli/templates/react/igr-ts/button/default/files/src/app/path/filePrefix.tsx | Adds sample Button view implementation. |
| packages/cli/templates/react/igr-ts/button/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Button view. |
| packages/cli/templates/react/igr-ts/button-group/index.ts | Adds Button group component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/button-group/default/index.ts | Adds Button group template metadata. |
| packages/cli/templates/react/igr-ts/button-group/default/files/src/app/path/style.module.css | Adds CSS module styles for the Button group view. |
| packages/cli/templates/react/igr-ts/button-group/default/files/src/app/path/filePrefix.tsx | Adds sample Button group view implementation. |
| packages/cli/templates/react/igr-ts/button-group/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Button group view. |
| packages/cli/templates/react/igr-ts/calendar/index.ts | Adds Calendar component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/calendar/default/index.ts | Adds Calendar template metadata. |
| packages/cli/templates/react/igr-ts/calendar/default/files/src/app/path/style.module.css | Adds CSS module styles for the Calendar view. |
| packages/cli/templates/react/igr-ts/calendar/default/files/src/app/path/filePrefix.tsx | Adds sample Calendar view implementation. |
| packages/cli/templates/react/igr-ts/calendar/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Calendar view. |
| packages/cli/templates/react/igr-ts/card/index.ts | Adds Card component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/card/default/index.ts | Adds Card template metadata. |
| packages/cli/templates/react/igr-ts/card/default/files/src/app/path/style.module.css | Adds CSS module styles for the Card view. |
| packages/cli/templates/react/igr-ts/card/default/files/src/app/path/filePrefix.tsx | Adds sample Card view implementation. |
| packages/cli/templates/react/igr-ts/card/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Card view. |
| packages/cli/templates/react/igr-ts/checkbox/index.ts | Adds Checkbox component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/checkbox/default/index.ts | Adds Checkbox template metadata. |
| packages/cli/templates/react/igr-ts/checkbox/default/files/src/app/path/style.module.css | Adds CSS module styles for the Checkbox view. |
| packages/cli/templates/react/igr-ts/checkbox/default/files/src/app/path/filePrefix.tsx | Adds sample Checkbox view implementation. |
| packages/cli/templates/react/igr-ts/checkbox/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Checkbox view. |
| packages/cli/templates/react/igr-ts/chip/index.ts | Adds Chip component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/chip/default/index.ts | Adds Chip template metadata. |
| packages/cli/templates/react/igr-ts/chip/default/files/src/app/path/style.module.css | Adds CSS module styles for the Chip view. |
| packages/cli/templates/react/igr-ts/chip/default/files/src/app/path/filePrefix.tsx | Adds sample Chip view implementation. |
| packages/cli/templates/react/igr-ts/chip/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Chip view. |
| packages/cli/templates/react/igr-ts/circular-progress/index.ts | Adds Circular Progress component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/circular-progress/default/index.ts | Adds Circular Progress template metadata. |
| packages/cli/templates/react/igr-ts/circular-progress/default/files/src/app/path/style.module.css | Adds CSS module styles for the Circular Progress view. |
| packages/cli/templates/react/igr-ts/circular-progress/default/files/src/app/path/filePrefix.tsx | Adds sample Circular Progress view implementation. |
| packages/cli/templates/react/igr-ts/circular-progress/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Circular Progress view. |
| packages/cli/templates/react/igr-ts/custom-templates/subscription-form/index.ts | Adds subscription-form custom template metadata (custom templates list). |
| packages/cli/templates/react/igr-ts/custom-templates/subscription-form/files/src/app/path/style.module.css | Adds CSS module styles for the subscription form view. |
| packages/cli/templates/react/igr-ts/custom-templates/subscription-form/files/src/app/path/filePrefix.tsx | Adds subscription form sample view implementation. |
| packages/cli/templates/react/igr-ts/custom-templates/subscription-form/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the subscription form view. |
| packages/cli/templates/react/igr-ts/date-picker/index.ts | Adds Date Picker component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/date-picker/default/index.ts | Adds Date Picker template metadata. |
| packages/cli/templates/react/igr-ts/date-picker/default/files/src/app/path/style.module.css | Adds CSS module styles for the Date Picker view. |
| packages/cli/templates/react/igr-ts/date-picker/default/files/src/app/path/filePrefix.tsx | Adds sample Date Picker view implementation. |
| packages/cli/templates/react/igr-ts/date-picker/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Date Picker view. |
| packages/cli/templates/react/igr-ts/divider/index.ts | Adds Divider component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/divider/default/index.ts | Adds Divider template metadata. |
| packages/cli/templates/react/igr-ts/divider/default/files/src/app/path/style.module.css | Adds CSS module styles for the Divider view. |
| packages/cli/templates/react/igr-ts/divider/default/files/src/app/path/filePrefix.tsx | Adds sample Divider view implementation. |
| packages/cli/templates/react/igr-ts/divider/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Divider view. |
| packages/cli/templates/react/igr-ts/dropdown/index.ts | Adds Dropdown component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/dropdown/default/index.ts | Adds Dropdown template metadata. |
| packages/cli/templates/react/igr-ts/dropdown/default/files/src/app/path/style.module.css | Adds CSS module styles for the Dropdown view. |
| packages/cli/templates/react/igr-ts/dropdown/default/files/src/app/path/filePrefix.tsx | Adds sample Dropdown view implementation. |
| packages/cli/templates/react/igr-ts/dropdown/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Dropdown view. |
| packages/cli/templates/react/igr-ts/expansion-panel/index.ts | Adds Expansion Panel component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/expansion-panel/default/index.ts | Adds Expansion Panel template metadata. |
| packages/cli/templates/react/igr-ts/expansion-panel/default/files/src/app/path/filePrefix.tsx | Adds sample Expansion Panel view implementation. |
| packages/cli/templates/react/igr-ts/expansion-panel/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Expansion Panel view. |
| packages/cli/templates/react/igr-ts/form/index.ts | Adds Form component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/form/default/index.ts | Adds Form template metadata. |
| packages/cli/templates/react/igr-ts/form/default/files/src/app/path/style.module.css | Adds CSS module styles for the Form view. |
| packages/cli/templates/react/igr-ts/form/default/files/src/app/path/filePrefix.tsx | Adds sample Form view implementation. |
| packages/cli/templates/react/igr-ts/form/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Form view. |
| packages/cli/templates/react/igr-ts/groups.json | Adds missing component group descriptions used by igr-ts templates. |
| packages/cli/templates/react/igr-ts/icon/index.ts | Adds Icon component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/icon/default/index.ts | Adds Icon template metadata. |
| packages/cli/templates/react/igr-ts/icon/default/files/src/app/path/style.module.css | Adds CSS module styles for the Icon view. |
| packages/cli/templates/react/igr-ts/icon/default/files/src/app/path/filePrefix.tsx | Adds sample Icon view implementation. |
| packages/cli/templates/react/igr-ts/icon/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Icon view. |
| packages/cli/templates/react/igr-ts/icon-button/index.ts | Adds Icon button component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/icon-button/default/index.ts | Adds Icon button template metadata. |
| packages/cli/templates/react/igr-ts/icon-button/default/files/src/app/path/style.module.css | Adds CSS module styles for the Icon button view. |
| packages/cli/templates/react/igr-ts/icon-button/default/files/src/app/path/filePrefix.tsx | Adds sample Icon button view implementation. |
| packages/cli/templates/react/igr-ts/icon-button/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Icon button view. |
| packages/cli/templates/react/igr-ts/input/index.ts | Adds Input component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/input/default/index.ts | Adds Input template metadata. |
| packages/cli/templates/react/igr-ts/input/default/files/src/app/path/style.module.css | Adds CSS module styles for the Input view. |
| packages/cli/templates/react/igr-ts/input/default/files/src/app/path/filePrefix.tsx | Adds sample Input view implementation. |
| packages/cli/templates/react/igr-ts/input/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Input view. |
| packages/cli/templates/react/igr-ts/linear-progress/index.ts | Adds Linear Progress component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/linear-progress/default/index.ts | Adds Linear Progress template metadata. |
| packages/cli/templates/react/igr-ts/linear-progress/default/files/src/app/path/style.module.css | Adds CSS module styles for the Linear Progress view. |
| packages/cli/templates/react/igr-ts/linear-progress/default/files/src/app/path/filePrefix.tsx | Adds sample Linear Progress view implementation. |
| packages/cli/templates/react/igr-ts/linear-progress/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Linear Progress view. |
| packages/cli/templates/react/igr-ts/list/index.ts | Adds List component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/list/default/index.ts | Adds List template metadata. |
| packages/cli/templates/react/igr-ts/list/default/files/src/app/path/style.module.css | Adds CSS module styles for the List view. |
| packages/cli/templates/react/igr-ts/list/default/files/src/app/path/filePrefix.tsx | Adds sample List view implementation. |
| packages/cli/templates/react/igr-ts/list/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the List view. |
| packages/cli/templates/react/igr-ts/navbar/index.ts | Adds Navbar component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/navbar/default/index.ts | Adds Navbar template metadata. |
| packages/cli/templates/react/igr-ts/navbar/default/files/src/app/path/style.module.css | Adds CSS module styles for the Navbar view. |
| packages/cli/templates/react/igr-ts/navbar/default/files/src/app/path/filePrefix.tsx | Adds sample Navbar view implementation. |
| packages/cli/templates/react/igr-ts/navbar/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Navbar view. |
| packages/cli/templates/react/igr-ts/radio-group/index.ts | Adds Radio Group component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/radio-group/default/index.ts | Adds Radio Group template metadata. |
| packages/cli/templates/react/igr-ts/radio-group/default/files/src/app/path/style.module.css | Adds CSS module styles for the Radio Group view. |
| packages/cli/templates/react/igr-ts/radio-group/default/files/src/app/path/filePrefix.tsx | Adds sample Radio Group view implementation. |
| packages/cli/templates/react/igr-ts/radio-group/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Radio Group view. |
| packages/cli/templates/react/igr-ts/rating/index.ts | Adds Rating component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/rating/default/index.ts | Adds Rating template metadata. |
| packages/cli/templates/react/igr-ts/rating/default/files/src/app/path/style.module.css | Adds CSS module styles for the Rating view. |
| packages/cli/templates/react/igr-ts/rating/default/files/src/app/path/filePrefix.tsx | Adds sample Rating view implementation. |
| packages/cli/templates/react/igr-ts/rating/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Rating view. |
| packages/cli/templates/react/igr-ts/ripple/index.ts | Adds Ripple component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/ripple/default/index.ts | Adds Ripple template metadata. |
| packages/cli/templates/react/igr-ts/ripple/default/files/src/app/path/style.module.css | Adds CSS module styles for the Ripple view. |
| packages/cli/templates/react/igr-ts/ripple/default/files/src/app/path/filePrefix.tsx | Adds sample Ripple view implementation. |
| packages/cli/templates/react/igr-ts/ripple/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Ripple view. |
| packages/cli/templates/react/igr-ts/slider/index.ts | Adds Slider component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/slider/default/index.ts | Adds Slider template metadata. |
| packages/cli/templates/react/igr-ts/slider/default/files/src/app/path/style.module.css | Adds CSS module styles for the Slider view. |
| packages/cli/templates/react/igr-ts/slider/default/files/src/app/path/filePrefix.tsx | Adds sample Slider view implementation. |
| packages/cli/templates/react/igr-ts/slider/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Slider view. |
| packages/cli/templates/react/igr-ts/switch/index.ts | Adds Switch component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/switch/default/index.ts | Adds Switch template metadata. |
| packages/cli/templates/react/igr-ts/switch/default/files/src/app/path/style.module.css | Adds CSS module styles for the Switch view. |
| packages/cli/templates/react/igr-ts/switch/default/files/src/app/path/filePrefix.tsx | Adds sample Switch view implementation. |
| packages/cli/templates/react/igr-ts/switch/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Switch view. |
| packages/cli/templates/react/igr-ts/tabs/index.ts | Adds Tabs component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/tabs/default/index.ts | Adds Tabs template metadata. |
| packages/cli/templates/react/igr-ts/tabs/default/files/src/app/path/style.module.css | Adds CSS module styles for the Tabs view. |
| packages/cli/templates/react/igr-ts/tabs/default/files/src/app/path/filePrefix.tsx | Adds sample Tabs view implementation. |
| packages/cli/templates/react/igr-ts/tabs/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Tabs view. |
| packages/cli/templates/react/igr-ts/text-area/index.ts | Adds Text area component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/text-area/default/index.ts | Adds Text area template metadata. |
| packages/cli/templates/react/igr-ts/text-area/default/files/src/app/path/style.module.css | Adds CSS module styles for the Text area view. |
| packages/cli/templates/react/igr-ts/text-area/default/files/src/app/path/filePrefix.tsx | Adds sample Text area view implementation. |
| packages/cli/templates/react/igr-ts/text-area/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Text area view. |
| packages/cli/templates/react/igr-ts/tree/index.ts | Adds Tree component metadata for template discovery. |
| packages/cli/templates/react/igr-ts/tree/default/index.ts | Adds Tree template metadata. |
| packages/cli/templates/react/igr-ts/tree/default/files/src/app/path/style.module.css | Adds CSS module styles for the Tree view. |
| packages/cli/templates/react/igr-ts/tree/default/files/src/app/path/filePrefix.tsx | Adds sample Tree view implementation. |
| packages/cli/templates/react/igr-ts/tree/default/files/src/app/path/filePrefix.test.tsx | Adds basic render smoke test for the Tree view. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+7
| this.components = ["LinearProgress"]; | ||
| this.controlGroup = "Data Entry & Display"; |
There was a problem hiding this comment.
Component metadata uses the name "Linear Progress", but this template uses "LinearProgress" (no space). This mismatch can prevent the template from being associated with the Linear Progress component. Update this.components to exactly match the component name.
Comment on lines
+6
to
+7
| this.components = ["CircularProgress"]; | ||
| this.controlGroup = "Data Entry & Display"; |
There was a problem hiding this comment.
Component metadata uses the name "Circular Progress", but this template uses "CircularProgress" (no space). This mismatch can prevent the template from being associated with the Circular Progress component. Update this.components to exactly match the component name.
Comment on lines
+6
to
+7
| this.components = ["DatePicker"]; | ||
| this.controlGroup = "Scheduling"; |
There was a problem hiding this comment.
The component metadata names this control "Date Picker", but the template lists this.components = ["DatePicker"]. Align these values so the template can be discovered for the component. If you're matching Web Components, consider renaming the component metadata to "DatePicker" (as in webcomponents/igc-ts/date-picker/index.ts) and keep the template value as-is.
| @@ -0,0 +1,17 @@ | |||
| import style from './style.module.css'; | |||
There was a problem hiding this comment.
style.module.css is imported here, but the file is missing from expansion-panel/default/files/src/app/__path__ (template generation will fail with a module-not-found error). Add the missing CSS module file (or remove the import/use of style.*).
Comment on lines
+5
to
+6
| export default function $(ClassName)() { | ||
| const handleSubmit = (event: React.FormEvent<HTMLFormElement>) => { |
There was a problem hiding this comment.
This file references React.FormEvent, but React isn't imported, so TypeScript will error (Cannot find name 'React'). Import the needed type from react (e.g., import type { FormEvent } from 'react') or import React and keep the current annotation.
| @@ -0,0 +1,31 @@ | |||
| import style from './style.module.css'; | |||
| import { IgrList, IgrListItem, IgrListHeader, IgrAvatar, IgrButton } from 'igniteui-react'; | |||
There was a problem hiding this comment.
IgrButton is imported but never used in this template. With the project's ESLint config (@typescript-eslint/no-unused-vars set to error), generated projects will fail linting. Remove the unused import or use IgrButton in the JSX.
| class IgrAccordionTemplate extends IgniteUIForReactTemplate { | ||
| constructor() { | ||
| super(__dirname); | ||
| this.components = ["IgrAccordion"]; |
There was a problem hiding this comment.
this.components should match the component name used by the component metadata (and the Web Components templates use the human-readable name, e.g. "Accordion"). Using "IgrAccordion" here will likely prevent this template from being associated with the Accordion component. Set this.components to "Accordion".
Suggested change
| this.components = ["IgrAccordion"]; | |
| this.components = ["Accordion"]; |
Comment on lines
+6
to
+7
| this.components = ["IgrDivider"]; | ||
| this.controlGroup = "Layouts"; |
There was a problem hiding this comment.
this.components should match the component name from the component metadata ("Divider"). Using "IgrDivider" may prevent the template from being discoverable under Divider. Set this.components to "Divider".
Comment on lines
+6
to
+8
| this.name = "Divider"; | ||
| this.group = "Layouts"; | ||
| this.description = `provides a thin, lightweight separator.`; |
There was a problem hiding this comment.
Divider is grouped under Layouts here, but the corresponding Web Components template/component groups Divider under Data Entry & Display. If the goal is to match the Web Components selection/grouping, update this.group to Data Entry & Display so it appears in the same category.
Comment on lines
+7
to
+8
| this.controlGroup = "Layouts"; | ||
| this.listInComponentTemplates = true; |
There was a problem hiding this comment.
this.controlGroup is set to Layouts, but Divider is categorized as Data Entry & Display in the Web Components templates. If this PR aims to align React templates with Web Components selection/grouping, use Data Entry & Display here so the template lists under the same group.
Member
|
@copilot As it is a dependency of |
…es for all React component templates Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/7d42465f-2e0a-4fcc-b339-d251517bf700 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
Contributor
Author
Fixed in 87759d4 — updated all 31 React component templates to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.