[jp-sync] docs(grid): sync JP styling sections to match updated EN samples#343
Merged
ChronosSF merged 4 commits intoJun 29, 2026
Merged
Conversation
Updated SCSS code blocks in JP hierarchical grid and tree grid docs to match the simplified styling approach used in the English source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
norikois
previously approved these changes
Jun 23, 2026
norikois
left a comment
norikois
left a comment
Contributor
There was a problem hiding this comment.
Simply approved because there are no changes in Japanese.
Member
Contributor
Done! Synced all 12
|
Member
|
@norikois , sorry we had an issue with the automated translation workflow that we have since resolved . For this case I just asked copilot to add the translation outside of the automation. Could you please check it the latest changes? |
mkamiishi
requested review from
mkamiishi and
norikois
and removed request for
norikois
Refine phrasing for clarity in Japanese documentation.
It looks like this translation does not match the original text. The original refers to styling the header title by extending query-builder-theme and setting the $header-foreground parameter, but the Japanese translation mentions $background, $foreground, and $accent-color instead. Could we revise it to align with the original?
mkamiishi
approved these changes
Jun 29, 2026
mkamiishi
left a comment
mkamiishi
left a comment
Contributor
There was a problem hiding this comment.
Please see the correction and comments on docs/angular/src/content/jp/components/grids_templates/advanced-filtering.mdx
ChronosSF
deleted the
jp-sync/update-grid-styling-samples-f8cb782332c66fdf
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author: adrianptrv (adrianptrv@users.noreply.github.com)
Syncs Japanese documentation with changes from PR #336 (merged by simeonoff).
Changed files
docs/angular/src/content/en/components/hierarchicalgrid/hierarchical-grid.mdxdocs/angular/src/content/jp/components/hierarchicalgrid/hierarchical-grid.mdxdocs/angular/src/content/en/components/treegrid/tree-grid.mdxdocs/angular/src/content/jp/components/treegrid/tree-grid.mdxdocs/angular/src/content/en/grids_templates/advanced-filtering.mdxdocs/angular/src/content/jp/grids_templates/advanced-filtering.mdxdocs/angular/src/content/en/grids_templates/cell-editing.mdxdocs/angular/src/content/jp/grids_templates/cell-editing.mdxdocs/angular/src/content/en/grids_templates/column-resizing.mdxdocs/angular/src/content/jp/grids_templates/column-resizing.mdxdocs/angular/src/content/en/grids_templates/column-selection.mdxdocs/angular/src/content/jp/grids_templates/column-selection.mdxdocs/angular/src/content/en/grids_templates/excel-style-filtering.mdxdocs/angular/src/content/jp/grids_templates/excel-style-filtering.mdxdocs/angular/src/content/en/grids_templates/multi-column-headers.mdxdocs/angular/src/content/jp/grids_templates/multi-column-headers.mdxdocs/angular/src/content/en/grids_templates/multi-row-layout.mdxdocs/angular/src/content/jp/grids_templates/multi-row-layout.mdxdocs/angular/src/content/en/grids_templates/paging.mdxdocs/angular/src/content/jp/grids_templates/paging.mdxdocs/angular/src/content/en/grids_templates/row-pinning.mdxdocs/angular/src/content/jp/grids_templates/row-pinning.mdxdocs/angular/src/content/en/grids_templates/sorting.mdxdocs/angular/src/content/jp/grids_templates/sorting.mdxdocs/angular/src/content/en/grids_templates/summaries.mdxdocs/angular/src/content/jp/grids_templates/summaries.mdxdocs/angular/src/content/en/grids_templates/toolbar.mdxdocs/angular/src/content/jp/grids_templates/toolbar.mdxSummary
Updated SCSS code blocks in the Styling sections of all 14 Japanese files to match the simplified theming approach in the English source. No prose (Japanese text) was changed — only the code block content was updated to stay in sync with the English source.
components/files$custom-theme: grid-theme(...)block with a cleaner three-variable pattern ($background,$foreground,$accent) and a minimal$custom-grid: grid-theme(...).:host { @include tokens($custom-theme); }→:host { @include tokens($custom-grid); }in both files.grids_templates/files$header-foregroundwith$background/$foreground/$accent-colorparams; removed redundant full theme block.$grid-themewith new params ($cell-editing-foreground,$cell-active-border-color); replaced@include grid(...)withComponentBlock-scoped@include palette + @include tokens.<ComponentBlock for="Grid">and added TreeGrid and HierarchicalGrid blocks with distinct resize-line colors.hsl()hover colors; added$row-selected-hover-text-colordescription.grid-themeusing$background/$foreground/$accent-color; addedexcel-filtering-themeto API references.ComponentBlocksections with distinct header colors.$cell-selected-text-color: #ffcd0f.$dark-paginator+$dark-buttonapproach with a single$paginator-themeusing$foreground/$background/$border-color/$accent-color.ComponentBlocksections with distinct themes; updated the CSS variables section with per-component include blocks.<ComponentBlock for="Grid, HierarchicalGrid">and added a TreeGrid block with different sorted-header colors.ComponentBlocksections with distinct color palettes.$grid-toolbar-themeusing$background/$border-color/$title-text-color/$item-hover-background.