Skip to content

fix(angular): point JP sample targets to the EN source#375

Merged
ChronosSF merged 4 commits into
vnextfrom
aahmedov/angular-jp-samples-en-source
Jun 30, 2026
Merged

fix(angular): point JP sample targets to the EN source#375
ChronosSF merged 4 commits into
vnextfrom
aahmedov/angular-jp-samples-en-source

Conversation

@Zneeky

@Zneeky Zneeky commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Closes #364

Summary

Switch the Angular JP sample targets to load from the English source instead of a separate JP demos deploy.

The JP docs were loading live samples from jp.*.infragistics.com/angular-demos, a second sample source that just duplicates the EN one. That adds unneeded maintenance/infra complexity. This points the JP demo base URLs at the EN host so JP consumes the English samples directly, allowing the duplicate JP demos deploy to be retired.

Changes

  • docs/angular/src/content/jp/environment.json — repoint the demo/sample base URLs (demosBaseUrl, dvDemosBaseUrl, lobDemosBaseUrl) for the staging and production blocks from the jp. host to the EN host:
    • staging: jp.staging.infragistics.com/angular-demos*staging.infragistics.com/angular-demos*
    • production: jp.infragistics.com/angular-demos*www.infragistics.com/angular-demos*
  • crmDemoBaseUrl and dvApiBaseUrl already pointed at the EN host (no change needed); the JP demo URLs now match EN exactly.
  • development block (localhost) and non-sample JP keys (infragisticsBaseUrl, sassApiUrl, GTMContainerId) are intentionally left untouched.

Verification

  • JSON validates; all three env blocks resolve to the expected hosts.
  • No remaining jp.*/angular-demos references in the JP content.
  • Staging build of the JP docs renders sample iframes against the EN host, e.g. https://staging.infragistics.com/angular-demos/grid/grid-rowStyles-sample (previously jp.staging.infragistics.com/...). Sample paths are unchanged, so existing sample references still resolve.

The JP docs loaded live samples from a separate JP demos deploy
(jp.*.infragistics.com/angular-demos) that just duplicated the EN one.
Point the JP demo/sample base URLs (demos, dv, lob) at the EN host
(staging/www.infragistics.com) so JP consumes the English samples and
the duplicate JP deploy can be retired.
@Zneeky Zneeky requested a review from Copilot June 26, 2026 12:05
@Zneeky Zneeky force-pushed the aahmedov/angular-jp-samples-en-source branch from 3d5fe5c to a7d8477 Compare June 26, 2026 12:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Angular JP docs environment configuration so that JP pages load live demo/sample content from the English (EN) demo hosts instead of the duplicate jp.* Angular demos deployments, reducing maintenance and infrastructure duplication.

Changes:

  • Repoint JP staging demo/sample base URLs from jp.staging.infragistics.com/angular-demos* to staging.infragistics.com/angular-demos*.
  • Repoint JP production demo/sample base URLs from jp.infragistics.com/angular-demos* to www.infragistics.com/angular-demos*.
  • Leave development (localhost) and non-sample JP-specific URLs (e.g., infragisticsBaseUrl, sassApiUrl, GTM IDs) unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Zneeky Zneeky requested a review from ChronosSF June 26, 2026 12:10
@Zneeky Zneeky added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 26, 2026
@ChronosSF ChronosSF merged commit 98e538e into vnext Jun 30, 2026
7 checks passed
@ChronosSF ChronosSF deleted the aahmedov/angular-jp-samples-en-source branch June 30, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch Sample targets for Angular JP to point to the English source

3 participants