Skip to content

update ig packages#475

Merged
dkamburov merged 12 commits intovnextfrom
dkamburov/update-ig-18.5.2-beta.1
Mar 21, 2024
Merged

update ig packages#475
dkamburov merged 12 commits intovnextfrom
dkamburov/update-ig-18.5.2-beta.1

Conversation

@dkamburov
Copy link
Copy Markdown
Contributor

No description provided.

@dkamburov dkamburov requested a review from IMinchev64 March 18, 2024 17:35
@mddifilippo89
Copy link
Copy Markdown
Contributor

@dkamburov Can you go back and update igniteui-webcomponents to v4.7.0 instead of downgrading to 4.5?

@dkamburov
Copy link
Copy Markdown
Contributor Author

yeah, sure

Copy link
Copy Markdown
Contributor

@IMinchev64 IMinchev64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there is something in this update that causes the Linear Progress Indicator Dynamic sample to break. The button to decrease the progress only increases it.

Additionally, the grid samples break and throw the following error:

Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at removeChildFromContainer (http://localhost:4200/static/js/bundle.js:29569:19)
    at commitDeletionEffectsOnFiber (http://localhost:4200/static/js/bundle.js:40596:19)
    at recursivelyTraverseDeletionEffects (http://localhost:4200/static/js/bundle.js:40562:9)
    at commitDeletionEffectsOnFiber (http://localhost:4200/static/js/bundle.js:40685:13)
    at recursivelyTraverseDeletionEffects (http://localhost:4200/static/js/bundle.js:40562:9)
    at commitDeletionEffectsOnFiber (http://localhost:4200/static/js/bundle.js:40685:13)
    at recursivelyTraverseDeletionEffects (http://localhost:4200/static/js/bundle.js:40562:9)
    at commitDeletionEffectsOnFiber (http://localhost:4200/static/js/bundle.js:40627:15)
    at recursivelyTraverseDeletionEffects (http://localhost:4200/static/js/bundle.js:40562:9)
    at commitDeletionEffectsOnFiber (http://localhost:4200/static/js/bundle.js:40589:15)

@mddifilippo89
Copy link
Copy Markdown
Contributor

dkamburov Stepper (linear) sample has a breaking change with index missing from the active step validation procedure. I just updated the sample so this PR doesn't break the browser. Someone should fix this sample so it behaves like WC.

@dkamburov dkamburov merged commit e96698f into vnext Mar 21, 2024
@dkamburov dkamburov deleted the dkamburov/update-ig-18.5.2-beta.1 branch March 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants